Do not pass NoneType as argument to ceph_crush_rule #7466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noonedeadpunk
force-pushed
the
bugfix/ceph_crush_rule_name_type
branch
2 times, most recently
from
cc6ca2e
to
10e3ae4
Compare
With ansible-core 2.15 it is not possible to pass argument of unexpected type, as otherwise module will fail with: `'None' is not a string and conversion is not allowed` With that we want to only get all existing crush rules, so we can simply supply an empty string as a name argument, which would satisfy requirements and have same behaviour for previous ansible versions. Alternative approach would be to stop making `name` as a required argument to the module and use empty string as default value when info state is used. Signed-off-by: Dmitriy Rabotyagov <noonedeadpunk@gmail.com>
noonedeadpunk
force-pushed
the
bugfix/ceph_crush_rule_name_type
branch
from
10e3ae4
to
9162d04
Compare
|
@guits would it be possible to review this PR? It's blocking some progress over in the OpenStack world. |
|
Reviews of this patch would be greatly appreciated, we are fast approaching a release deadline for OpenStack and this error is blocking ceph support in the OpenStack-Ansible project. |
asm0deuz
added
backport-stable-6.0
backport-stable-7.0
and removed
backport-stable-5.0
labels
This was referenced Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With ansible-core 2.15 it is not possible to pass argument of unexpected
type, as otherwise module will fail with:
'None' is not a string and conversion is not allowedWith that we want to only get all existing crush rules, so we can simply
supply an empty string as a name argument, which would satisfy
requirements and have same behaviour for previous ansible versions.
Alternative approach would be to stop making
nameas a requiredargument to the module and use empty string as default value
when info state is used.