-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceph-build: Install latest rpm macros #1283
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should make sure that all the rpm and srpm macros are installed and at the latest version before installing the build dependencies. Otherwise, the macros can get updated and we might not get all the dependencies installed with yum-builddep. Signed-off-by: Boris Ranto <branto@redhat.com>
alfredodeza
approved these changes
Apr 8, 2019
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Apr 9, 2019
as we have the rpm macros installed in ceph/ceph-build#1283 . Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Apr 10, 2019
we install the latest python-rpm-macros on all builders since ceph/ceph-build#1283 . so we started building python36-* after that change, for testing the python3 packages on CentOS/RHEL 7, we need to install python36-* instead of python34-*. Signed-off-by: Kefu Chai <kchai@redhat.com> Conflicts: this change is not cherry-picked from master, because, in master, we don't install python3 packages after 7e5c85b.
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Apr 10, 2019
we install the latest python-rpm-macros on all builders since ceph/ceph-build#1283 . so we started building python36-* after that change, for testing the python3 packages on CentOS/RHEL 7, we need to install python36-* instead of python34-*. Fixes: http://tracker.ceph.com/issues/39164 Signed-off-by: Kefu Chai <kchai@redhat.com> Conflicts: this change is not cherry-picked from master, because, in master, we don't install python3 packages after 7e5c85b.
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Apr 10, 2019
as we have the rpm macros installed in ceph/ceph-build#1283 . Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 11f0b8d)
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Apr 10, 2019
we install the latest python-rpm-macros on all builders since ceph/ceph-build#1283 . so we started building python36-* after that change, for testing the python3 packages on CentOS/RHEL 7, we need to install python36-* instead of python34-*. Fixes: http://tracker.ceph.com/issues/39164 Signed-off-by: Kefu Chai <kchai@redhat.com> Conflicts: this change is not cherry-picked from master, because, in master, we don't install python3 packages after 7e5c85b.
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Apr 10, 2019
we install the latest python-rpm-macros on all builders since ceph/ceph-build#1283 . now that we started building python36-* after that change, for testing the python3 packages on CentOS/RHEL 7, we need to install python36-* instead of python34-*. and after the change of 8ae1947, python36-* now "Provides" python3-*, we can just install python3-* for fulfill the requirement for testing python3 cephfs bindings. Fixes: http://tracker.ceph.com/issues/39164 Signed-off-by: Kefu Chai <kchai@redhat.com> Conflicts: this change is not cherry-picked from master, because, in master, we don't install python3 packages after 7e5c85b.
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Apr 11, 2019
…tests EPEL7 has switched over to python3.6 as the main python3. and we started packaging python bindings for python3.6 since ceph/ceph-build#1283 Signed-off-by: Kefu Chai <kchai@redhat.com>
3 tasks
tchaikov
added a commit
to tchaikov/teuthology
that referenced
this pull request
Apr 11, 2019
EPEL7 has switched over to python3.6 as the main python3. and we started packaging python bindings for python3.6 since ceph/ceph-build#1283 Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Apr 11, 2019
as we have the rpm macros installed in ceph/ceph-build#1283 . Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 11f0b8d)
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Apr 11, 2019
…tests EPEL7 has switched over to python3.6 as the main python3. and we started packaging python bindings for python3.6 since ceph/ceph-build#1283 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 42167b8)
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Apr 11, 2019
…tests EPEL7 has switched over to python3.6 as the main python3. and we started packaging python bindings for python3.6 since ceph/ceph-build#1283 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 42167b8)
3 tasks
thmour
pushed a commit
to thmour/ceph
that referenced
this pull request
Jun 7, 2019
as we have the rpm macros installed in ceph/ceph-build#1283 . Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 11f0b8d)
thmour
pushed a commit
to thmour/ceph
that referenced
this pull request
Jun 7, 2019
we install the latest python-rpm-macros on all builders since ceph/ceph-build#1283 . now that we started building python36-* after that change, for testing the python3 packages on CentOS/RHEL 7, we need to install python36-* instead of python34-*. and after the change of 8ae1947, python36-* now "Provides" python3-*, we can just install python3-* for fulfill the requirement for testing python3 cephfs bindings. Fixes: http://tracker.ceph.com/issues/39164 Signed-off-by: Kefu Chai <kchai@redhat.com> Conflicts: this change is not cherry-picked from master, because, in master, we don't install python3 packages after 7e5c85b.
thmour
pushed a commit
to thmour/ceph
that referenced
this pull request
Jun 7, 2019
…tests EPEL7 has switched over to python3.6 as the main python3. and we started packaging python bindings for python3.6 since ceph/ceph-build#1283 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 42167b8)
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Jun 11, 2019
as we have the rpm macros installed in ceph/ceph-build#1283 . Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 11f0b8d)
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Jun 11, 2019
…tests EPEL7 has switched over to python3.6 as the main python3. and we started packaging python bindings for python3.6 since ceph/ceph-build#1283 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 42167b8)
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Jun 11, 2019
we install the latest python-rpm-macros on all builders since ceph/ceph-build#1283 . now that we started building python36-* after that change, for testing the python3 packages on CentOS/RHEL 7, we need to install python36-* instead of python34-*. and after the change of 8ae1947, python36-* now "Provides" python3-*, we can just install python3-* for fulfill the requirement for testing python3 cephfs bindings. Fixes: http://tracker.ceph.com/issues/39164 Signed-off-by: Kefu Chai <kchai@redhat.com> Conflicts: this change is not cherry-picked from master, because, in master, we don't install python3 packages after 7e5c85b. (cherry picked from commit 6790821)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should make sure that all the rpm and srpm macros are installed and
at the latest version before installing the build dependencies.
Otherwise, the macros can get updated and we might not get all the
dependencies installed with yum-builddep.
Signed-off-by: Boris Ranto branto@redhat.com