Fix for issue #171 #203
Fix for issue #171 #203
Conversation
|
This seems like a good idea, and I appreciate the effort. I'd rather see this patch go to the upstream ceph-disk rather than maintaining a local patch. Have you tried there yet? |
|
The upstream project will get a pull request just as soon as I'm done Figured I'd at least get something to ceph-docker in the meantime, since Mike Shuey On Mon, Jan 25, 2016 at 3:56 PM, Seán C. McCord notifications@github.com
|
|
Sounds good. I'm a bit concerned with the local patch adding brittleness, but at least that should fail at image-build time, if it doesn't patch cleanly. @leseb , thoughts? |
|
Same concern here, I'd prefer to have this getting merged in Thanks! |
fmeppo
force-pushed
the
master
branch
3 times, most recently
from
5be1b3c
to
89ed955
Compare
|
This patch has been rebased into upstream, and there's a pull request (#7351) in queue. Also added a few comments about that, indicating it can be removed after the PR is done. |
| @@ -7,8 +7,11 @@ | |||
| FROM ceph/base | |||
| MAINTAINER Sébastien Han "seb@redhat.com" | |||
|
|
|||
| # patch is only needed until PR #7531 is merged in ceph/ceph (and backported | |||
|
Yeah...sorry about that. Comment fixed. |
| RUN apt-get update && apt-get -y install runit && \ | ||
| apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* | ||
| apt-get install patch && \ |
There was a problem hiding this comment.
just to be sure, shouldn't we use -y in apt?
There was a problem hiding this comment.
It works as-is, but....you're probably right. Committed a fix; it's in the
pull request now.
Mike Shuey
On Wed, Feb 10, 2016 at 9:22 AM, Leseb notifications@github.com wrote:
In daemon/Dockerfile
#203 (comment):RUN apt-get update && apt-get -y install runit &&
-apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*
- apt-get install patch && \
just to be sure, shouldn't we use -y in apt?
—
Reply to this email directly or view it on GitHub
https://github.com/ceph/ceph-docker/pull/203/files#r52462522.
Signed-off-by: Mike Shuey <shuey@purdue.edu>
Signed-off-by: Mike Shuey <shuey@purdue.edu>
Signed-off-by: Mike Shuey <shuey@purdue.edu>
Signed-off-by: Mike Shuey <shuey@purdue.edu>
previously-initialized disks) Signed-off-by: Mike Shuey <shuey@purdue.edu>
…self) can be removed. Signed-off-by: Mike Shuey <shuey@purdue.edu>
Signed-off-by: Mike Shuey <shuey@purdue.edu>
|
Thanks @fmeppo! |
This pull provides a patch to ceph-disk, allowing the permissions to be overridden. A disk-type OSD will then run with perms ceph:disk, so it can get raw block dev access for the journal file.