Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use update for kubernetes csidriver object when required #55

Closed
Madhu-1 opened this issue Jul 26, 2024 · 1 comment
Closed

Use update for kubernetes csidriver object when required #55

Madhu-1 opened this issue Jul 26, 2024 · 1 comment

Comments

@Madhu-1
Copy link
Collaborator

Madhu-1 commented Jul 26, 2024 

          I assume this means it'll be essentially recreating the driver for all cases and that the nested conditions above were purposely written to allow it. Why not use separate `Update` and `Create` in this context? Is it the same argument you've made in my PR?

Originally posted by @raaizik in #24 (comment)
@Madhu-1
Copy link
Collaborator Author

Madhu-1 commented Aug 5, 2024

Fixed in #84

@Madhu-1 Madhu-1 closed this as completed Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Madhu-1