-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Driver API reconciliation #24
Conversation
aa1fe45
to
d935b17
Compare
beda133
to
1edde70
Compare
dd95cb8
to
2832a7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed only a 3rd portion I guess, will do the rest in another round, pls excuse.
f5a0b45
to
badc03f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reviewed around 2/3 rd, will do the rest after the updates.
badc03f
to
1357d08
Compare
cf2b0f6
to
07100fd
Compare
b8523e8
to
ec54f4d
Compare
- validate driver name structure - parse and split driver name into short name and driver type - load desired driver resource Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
…rge them Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
Signed-off-by: nb-ohad <mitrani.ohad@gmail.com>
ec54f4d
to
badf2d6
Compare
While installing node plugin pods I see
|
Describe what this PR does
The PR implements driver API reconciliation.
Is there anything that requires special attention
This PR does not include tests that cover the above changes.
A second PR for test implementation will come later
Future concerns
List items that are not part of the PR and do not impact it's
functionality, but are work items that can be taken up subsequently.