Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update relative path to ceph-config.yaml file #3273

Merged
merged 1 commit into from
Aug 4, 2022

Conversation

palvarez89
Copy link
Contributor

@palvarez89 palvarez89 commented Jul 29, 2022

Describe what this PR does

I know is not explicit, but all the previous steps kind of assume that you are on deploy/cephfs/kubernetes folder, making the current relative path to the example folder not work.

@humblec
Copy link
Collaborator

humblec commented Jul 29, 2022

Thanks @palvarez89 for the contribution 👍 .

The DCO check fails due to missing signed-off , details @ https://github.com/ceph/ceph-csi/pull/3273/checks?check_run_id=7578535756

@@ -164,7 +164,7 @@ for more information.
**Deploy Ceph configuration ConfigMap for CSI pods:**

```bash
kubectl create -f ../example/ceph-config.yaml
kubectl create -f ../../../example/ceph-config.yaml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain in the commit message why this is needed? If the file is relative to this document, a single ../ seems sufficient.

Note that other files are referenced without a path. If this gets corrected, other references should be adapted too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know is not explicit, but all the previous steps kind of assume that you are on deploy/cephfs/kubernetes folder, making the current relative path to the example folder not work.

If this reason is good enough for you, I can update the commit message.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, that's fine with me. It would be great if you can update the commit message and adjust the subject of your commit as well. I recommend doc: update relative path to ceph-config.yaml file, the doc: prefix should be valid for the commitlint check. Make sure to add your Signed-off-by as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pointers. I hadn't noticed the CI failures yet.

@nixpanic nixpanic added component/deployment Helm chart, kubernetes templates and configuration Issues/PRs component/docs Issues and PRs related to documentation ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures labels Jul 29, 2022
@nixpanic nixpanic added the DNM DO NOT MERGE label Aug 3, 2022
Copy link
Member

@nixpanic nixpanic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good to me. I have added the do not merge label for the time being, so that other PRs don't need to rebase and retest once this gets merged without full e2e testing.

This one is next once the other PR is merged.

@nixpanic nixpanic requested a review from a team August 3, 2022 10:37
@nixpanic nixpanic removed the DNM DO NOT MERGE label Aug 4, 2022
Signed-off-by: Pedro Alvarez <pedro.alvarez@softiron.com>
@mergify mergify bot merged commit 3c3cbc8 into ceph:devel Aug 4, 2022
@palvarez89 palvarez89 deleted the patch-2 branch August 4, 2022 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip/e2e skip running e2e CI jobs ci/skip/multi-arch-build skip building on multiple architectures component/deployment Helm chart, kubernetes templates and configuration Issues/PRs component/docs Issues and PRs related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants