cephfs: delete subvolume if SetAllMetadata fails #3435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Madhu-1
added
component/cephfs
Rakshith-R
approved these changes
Oct 17, 2022
nixpanic
approved these changes
Oct 17, 2022
|
@Mergifyio rebase |
To avoid subvolume leaks if the SetAllMetadata operations fails delete the subvolume. If any operation fails after creating the subvolume we will remove the omap as the omap gets removed we will need to remove the subvolume to avoid stale resources. Signed-off-by: Madhu Rajanna <madhupr007@gmail.com>
✅ Branch has been successfully rebased |
leseb
force-pushed
the
fix-cephfs-leak
branch
from
2a82e6c
to
100243e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid subvolume leaks if the SetAllMetadata operations fails delete the subvolume.
If any operation fails after creating the subvolume we will remove the omap as the omap gets removed we will need to remove the subvolume to avoid stale resources.
Signed-off-by: Madhu Rajanna madhupr007@gmail.com