-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Use temporary directory for unit tests #4626
Conversation
a52f7d2
to
2364571
Compare
@iPraveenParihar Hopefully now it meets the requirement |
@mayankpall, please look at the following error and update the commit body. ✖ body's lines must not be longer than 80 characters [body-max-line-length] |
2364571
to
a19981e
Compare
![]() @iPraveenParihar edited it to shortest as possible. |
@iPraveenParihar all checks have passed |
Pull request has been modified.
@Madhu-1 removed err = os.Mkdir("/etc/ceph-csi-config", 0o600) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please squash all the commits into a single commit.
81055a6
to
51595e3
Compare
@Madhu-1 removed and squashed all the commits |
@Madhu-1, can we skip e2e tests for this PR? Since changes are in unit tests? |
yes that make sense, we can skip multi-arch buil and E2E for this kind of PR's |
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
51595e3
to
ed5129d
Compare
@Mergifyio queue |
🛑 The pull request has been removed from the queue
|
@Mergifyio refresh |
✅ Pull request refreshed |
@Mergifyio queue default |
🛑 The pull request has been removed from the queue
|
@Rakshith-R, can you take look at this? Mergifyio can't queue due to
|
@Mergifyio rebase |
ensure a clean and isolated environment for testing purposes. Signed-off-by: Mayank Pal <mayankpal9654@gmail.com> ci: Use temporary directory for unit tests remove err = os.Mkdir('/etc/ceph-csi-config', 0o600) Signed-off-by: Mayank Pal <mayankpal9654@gmail.com> ci: Use temporary directory for unit tests remove err = os.Mkdir('/etc/ceph-csi-config', 0o600) Signed-off-by: Mayank Pal <mayankpal9654@gmail.com> ci: Use temporary directory for unit tests remove if err Signed-off-by: Mayank Pal <mayankpal9654@gmail.com>
ed5129d
to
84719b2
Compare
✅ Branch has been successfully rebased |
@Mergifyio queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 822794c |
/test ci/centos/upgrade-tests-cephfs |
/test ci/centos/k8s-e2e-external-storage/1.29 |
/test ci/centos/k8s-e2e-external-storage/1.28 |
/test ci/centos/k8s-e2e-external-storage/1.27 |
/test ci/centos/upgrade-tests-rbd |
/test ci/centos/mini-e2e-helm/k8s-1.29 |
/test ci/centos/mini-e2e-helm/k8s-1.28 |
/test ci/centos/mini-e2e-helm/k8s-1.27 |
/test ci/centos/mini-e2e/k8s-1.29 |
/test ci/centos/mini-e2e/k8s-1.28 |
/test ci/centos/mini-e2e/k8s-1.27 |
/test ci/centos/k8s-e2e-external-storage/1.30 |
/test ci/centos/mini-e2e-helm/k8s-1.30 |
/test ci/centos/mini-e2e/k8s-1.30 |
ci: Use temporary directory for unit tests
This commit implements the use of a temporary directory for unit tests in order to ensure a clean and isolated environment for testing purposes.
Signed-off-by: Mayank Pal mayankpal9654@gmail.com
Fixes #4617