[RFC] ceph iscsi config: add max_data_area setting #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillaman
reviewed
Oct 23, 2017
|
Ok. Will fix. |
|
@mikechristie alternative PR #32 |
Allow users to config the tcmu data area ring size. This reqiures a updated kernel with the patch: ://www.spinics.net/lists/target-devel/msg16140.htmlttps://www.spinics.net/lists/target-devel/msg16097.html and a updated rtslib with this PR merged: open-iscsi/rtslib-fb#112 Signed-off-by: Mike Christie <mchristi@redhat.com>
|
lgtm -- pending rtslib_fb change |
|
Dropping this PR. Following the idea here where we do not want to update every tool/lib in the stack to add a setting, we can modify rtslib-fb and our tools/libs to take control settings after the initial object initialization but before enablement, and we can do the same for ceph-iscsi-config/gwcli. Will make new PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to config the tcmu data area ring size.
This reqiures a updated kernel with the patch:
https://www.spinics.net/lists/target-devel/msg16097.html
and a updated rtslib with this PR merged:
open-iscsi/rtslib-fb#112
This is marked a RFC because we are still waiting on upstream testing/review, so the patch should not be merged yet.