New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
18.2.0 #17
base: master
Are you sure you want to change the base?
18.2.0 #17
Conversation
thanks @NitzanMordhai! is there a good way to run main's dencoder tests against this before merging? i noticed that we're also missing the corpus for 17.2.0, so i'm working to generate that as well |
@cbodley yes, after you have that submodule update in your main, you can run src/test/encoding/readable.sh script, it will validate the main dencoder against that new version object repository and try to decode them and compare them to find if it is able to decode. |
ty, i didn't realize it was a submodule. i pushed ceph/ceph#54735 which points the submodule at this PR to see the checks run. hopefully that's enough to validate this and get it merged? |
it would be really nice to have this in place for squid testing |
@neha-ojha @rzarzynski can you please review that? |
0a8154c
to
4122de6
Compare
Signed-off-by: Nitzan Mordechai nmordech@redhat.com