Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dencoder: update ceph-object-corpus submodule for 18.2.0 coverage #54735

Merged
merged 1 commit into from Apr 3, 2024

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Nov 30, 2023

pull in submodule changes from ceph/ceph-object-corpus#17

Show available Jenkins commands
  • jenkins retest this please
  • jenkins test classic perf
  • jenkins test crimson perf
  • jenkins test signed
  • jenkins test make check
  • jenkins test make check arm64
  • jenkins test submodules
  • jenkins test dashboard
  • jenkins test dashboard cephadm
  • jenkins test api
  • jenkins test docs
  • jenkins render docs
  • jenkins test ceph-volume all
  • jenkins test ceph-volume tox
  • jenkins test windows
  • jenkins test rook e2e

@cbodley
Copy link
Contributor Author

cbodley commented Nov 30, 2023

The following tests FAILED:
147 - readable.sh (Failed)

**** reencode of /home/jenkins-build/build/workspace/ceph-pull-requests/ceph-object-corpus/archive/18.2.0/objects/chunk_refs_t/ccb69d9ecd572c1f6ed9598899773cf1 resulted in a different dump ****

@NitzanMordhai
Copy link
Contributor

@cbodley let me check it, chunk_refs_t changed to be non deterministic, it could be that we will need first merge the common changes for dencoder first

Copy link

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

Copy link

This pull request has been automatically marked as stale because it has not had any activity for 60 days. It will be closed if no further activity occurs for another 30 days.
If you are a maintainer or core committer, please follow-up on this pull request to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@github-actions github-actions bot added the stale label Feb 11, 2024
@cbodley
Copy link
Contributor Author

cbodley commented Mar 6, 2024

hey @NitzanMordhai, what more do we need to do to validate this? does ceph/ceph-object-corpus#17 need a rebase in order to pass 'make check' here?

@github-actions github-actions bot removed the stale label Mar 6, 2024
@NitzanMordhai
Copy link
Contributor

hey @NitzanMordhai, what more do we need to do to validate this? does ceph/ceph-object-corpus#17 need a rebase in order to pass 'make check' here?

#52210 was merge, we can rebase that one and the make check should resolve

@cbodley cbodley force-pushed the wip-corpus-18.2.0 branch 2 times, most recently from c48019b to 4b68a7c Compare March 6, 2024 18:00
@cbodley cbodley changed the title DNM: test ceph-object-corpus for 18.2.0 dencoder: update ceph-object-corpus submodule for 18.2.0 coverage Mar 6, 2024
@cbodley
Copy link
Contributor Author

cbodley commented Mar 6, 2024

now points the submodule at the rebased branch ceph/ceph-object-corpus#17

@cbodley cbodley requested a review from rzarzynski March 6, 2024 19:22
@cbodley
Copy link
Contributor Author

cbodley commented Mar 6, 2024

289/290 Test #148: readable.sh ...............................***Failed 2621.41 sec

/tmp/test_object_1-3bwS7gIZl /tmp/test_object_2-cFY7UCrpP differ: byte 133, line 8
**** reencode of /home/jenkins-build/build/workspace/ceph-pull-requests/ceph-object-corpus/archive/18.2.0/objects/chunk_refs_t/ccb69d9ecd572c1f6ed9598899773cf1 resulted in a different dump ****
8c8
<             "hash": 684235776,
---
>             "hash": 1703915520,
13c13
<             "hash": 684235777,
---
>             "hash": 1703915521,

that looks like the same chunk_refs_t failure identified above

Copy link

github-actions bot commented Mar 9, 2024

This pull request can no longer be automatically merged: a rebase is needed and changes have to be manually resolved

@NitzanMordhai
Copy link
Contributor

jenkins test make check

@NitzanMordhai
Copy link
Contributor

jenkins test make check

@NitzanMordhai
Copy link
Contributor

@cbodley we have an issue with chunk_refs on clang, the value for hash wasn't initilized, and thats the reason it happened. I was able to recreate the error.

@NitzanMordhai
Copy link
Contributor

wait to #56136

@rzarzynski
Copy link
Contributor

Asked Laura & Yuri to prioritize the dependency.

Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
Copy link
Contributor Author

cbodley commented Apr 2, 2024

wait to #56136

that merged, so i've pushed a fresh rebase

@cbodley
Copy link
Contributor Author

cbodley commented Apr 3, 2024

291/293 Test #148: readable.sh ............................... Passed 1215.70 sec

👍

@cbodley cbodley removed the request for review from a team April 3, 2024 12:39
@cbodley
Copy link
Contributor Author

cbodley commented Apr 3, 2024

@neha-ojha @rzarzynski this is ready for review

@rzarzynski rzarzynski merged commit b3cf8ca into ceph:main Apr 3, 2024
11 of 13 checks passed
@cbodley
Copy link
Contributor Author

cbodley commented Apr 3, 2024

thanks @NitzanMordhai, thanks @rzarzynski!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants