Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hammer: Testing: SIGABRT in TrackedOp::dump() via dump_ops_in_flight() #1081

Closed
wants to merge 8 commits into from

Conversation

dzafman
Copy link
Collaborator

@dzafman dzafman commented Jul 12, 2016

Backport 3 pull requests and add fix specifically for Hammer not to use osd.* since it crashes the command.

#344
#911
#1122

tchaikov and others added 5 commits July 12, 2016 15:46
* add a wrapper to log uncaught exception to self.logger, greenlet also
  prints the backtrace and exception to stderr, but teuthology.log does
  not capture stderr. so we need to catch them by ourselves to reveal
  more info to root-cause this issue.
* log uncaught exception thrown by Thrasher.do_thrash() to self.log.

See: #10630
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 64de3cd)
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 4ad3b86)
Add dump_ops_enable which continuously dumps ops using 3 commands
Add optrack_toggle_delay to alternate op tracking enablement

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 7a52876)

Conflicts:
	tasks/ceph_manager.py (trivial)
	tasks/thrashosds.py (trivial)
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 447bf87)
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit a595651)
@dzafman dzafman changed the title DNM: Wip 16225 Testing for hammer: SIGABRT in TrackedOp::dump() via dump_ops_in_flight() Jul 19, 2016
@dzafman dzafman removed the needs-qa label Jul 19, 2016
@dzafman
Copy link
Collaborator Author

dzafman commented Jul 19, 2016

Only merge with ceph/ceph#10255

@dzafman
Copy link
Collaborator Author

dzafman commented Jul 22, 2016

For some reason I got 11 crashes of python during a rados:thrash run. Using strings on the cores revealed a common strings:

/usr/bin/python /usr/bin/ceph tell osd.* injectargs --osd_enable_op_tracker=...

http://pulpito.ceph.com/dzafman-2016-07-12_16:03:42-rados:thrash-wip-zafman-testing-hammer---basic-smithi/

@dzafman dzafman changed the title Testing for hammer: SIGABRT in TrackedOp::dump() via dump_ops_in_flight() hammer: Testing: SIGABRT in TrackedOp::dump() via dump_ops_in_flight() Jul 22, 2016
@dzafman dzafman changed the title hammer: Testing: SIGABRT in TrackedOp::dump() via dump_ops_in_flight() DNM: hammer: Testing: SIGABRT in TrackedOp::dump() via dump_ops_in_flight() Jul 29, 2016
Signed-off-by: David Zafman <dzafman@redhat.com>
Needed to add stdout option to pass down to run()

Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit d762fa5)
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit 9d52d10)

Conflicts:
	tasks/ceph_manager.py (trivial)
@dzafman
Copy link
Collaborator Author

dzafman commented Aug 19, 2016

The last 2 commits come from #1122 which hasn't merged yet

@dzafman
Copy link
Collaborator Author

dzafman commented Aug 19, 2016

@dzafman dzafman added this to the hammer milestone Aug 19, 2016
@smithfarm
Copy link
Contributor

@dzafman Can we remove DNM now? I have prepared a hammer-backports integration branch - see http://tracker.ceph.com/issues/17151#note-6 - that includes ceph/ceph#10255 and IIUC I will need this PR to test it.

@dzafman dzafman changed the title DNM: hammer: Testing: SIGABRT in TrackedOp::dump() via dump_ops_in_flight() hammer: Testing: SIGABRT in TrackedOp::dump() via dump_ops_in_flight() Nov 18, 2016
@dzafman
Copy link
Collaborator Author

dzafman commented Nov 28, 2016

Superseded by #1278

@dzafman dzafman closed this Nov 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants