Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of firefly-giant-x suite #135

Merged
merged 1 commit into from Sep 26, 2014
Merged

First draft of firefly-giant-x suite #135

merged 1 commit into from Sep 26, 2014

Conversation

yuriw
Copy link
Contributor

@yuriw yuriw commented Sep 13, 2014

@liewegas pls review and merge

Signed-off-by: Yuri Weinstein yuri.weinstein@inktank.com

Signed-off-by: Yuri Weinstein <yuri.weinstein@inktank.com>
log-whitelist:
- scrub mismatch
- ScrubResult
roles:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to have more OSDs ( 15 maybe ) to test the LRC erasure code plugin which needs at least 8 of them.

@yuriw
Copy link
Contributor Author

yuriw commented Sep 15, 2014

@dachary do you think it should be specific to this suite?

@ghost
Copy link

ghost commented Sep 15, 2014

@yuriw I think it should be for all suites for which we want to run a lrc workload, meaning all suites including giant I suppose

@liewegas
Copy link
Member

It's fine to add lots of OSDs, but it will get slow because they will stop being mapped to actual disks (and will live on / instead). I don't think we should do that for the generic tests. Instead, we should make a EC specific collection of tests for these cases that need lots of OSDs ...

@yuriw
Copy link
Contributor Author

yuriw commented Sep 15, 2014

@liewegas "a EC specific collection of tests" you mean add special suites for this?

@liewegas
Copy link
Member

or a subdir with just the lrc stuff. Not sure where best to slot it in for upgrade, but for the rados suite, i think we need a rados/ec/ collection.

@yuriw
Copy link
Contributor Author

yuriw commented Sep 15, 2014

@liewegas @dachary it sounds like a standalone issue that will have to be addressed.
Back to the original PR for firefly-giant-x
If agree that we need it - pls merge. There was an opinion (we discussed with Josh @jdurgin ) that the coverage by dumpling-giant-x will suffice.

@yuriw
Copy link
Contributor Author

yuriw commented Sep 19, 2014

This suite should be added at later time when we have cleaned up giant branch and have other suites in "green" state per chat with Sage.

tmuthamizhan pushed a commit that referenced this pull request Sep 26, 2014
First draft of firefly-giant-x suite
@tmuthamizhan tmuthamizhan merged commit 24a5212 into master Sep 26, 2014
@tmuthamizhan
Copy link
Contributor

looks fine to me

1 similar comment
@tmuthamizhan
Copy link
Contributor

looks fine to me

@yuriw
Copy link
Contributor Author

yuriw commented Sep 26, 2014

@tmuthamizhan looks merged to me, thx!

@zmc zmc deleted the wip_9398 branch August 24, 2016 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants