hammer: fix ceph-deploy task with CephFS (#11316) #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
👍 |
|
The master version of this has passed stuff; anything else needed to merge? |
added 4 commits
April 21, 2015 14:14
Move up into Filesystem so that this can be used from the ceph_deploy task as well. Signed-off-by: John Spray <john.spray@redhat.com> (cherry picked from commit ea7c392)
... s/mon_remote/admin_remote/ and allow caller to pass in which remote they want to use for that. Enables use with ceph_deploy task which does not give admin keys to mons. Signed-off-by: John Spray <john.spray@redhat.com> (cherry picked from commit 8b61310)
...so that we may be used with the ceph_deploy task that doesn't set that up. Signed-off-by: John Spray <john.spray@redhat.com> (cherry picked from commit f360110)
This test apparently had not been touched since "fs new" was added. In addition to calling Filesystem.create: * modify the get_nodes_using_role function to modify ctx.cluster.remotes so that the service IDs match what ceph-deploy will set * log exceptions during ceph_deploy setup, as otherwise they can get lost if another exception occurs during teardown (so that it's all easier to debug). * default to passing --dev=master during install, so that we don't error out horribly when run without an explicit branch set (e.g. when run outside scheduled suite) Fixes: #11316 Signed-off-by: John Spray <john.spray@redhat.com> (cherry picked from commit 7c2e6cd)
|
Refer to this link for build results (access rights to CI server needed): |
|
Re-cherry-picked to have it match up nicely with master, should be good to go |
gregsfortytwo
added a commit
that referenced
this pull request
Apr 21, 2015
hammer: fix ceph-deploy task with CephFS (#11316)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't a nice "cherry-pick -x" backport because master version of this is waiting for #383