Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tasks/cephfs: time out on ceph-fuses that don't die #453

Merged
merged 2 commits into from Sep 21, 2015
Merged

tasks/cephfs: time out on ceph-fuses that don't die #453

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07eb03a
tasks/cephfs: time out on ceph-fuses that don't die
Jun 3, 2015
f97fde6
tasks/cephfs: switch unmount timeout to 15 minutes
gregsfortytwo Sep 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 7 additions & 1 deletion tasks/cephfs/fuse_mount.py
View file
Open in desktop
Expand Up @@ -7,6 +7,7 @@
from textwrap import dedent

from teuthology import misc
from teuthology.contextutil import MaxWhileTries
from teuthology.orchestra import run
from teuthology.orchestra.run import CommandFailedError
from .mount import CephFSMount
Expand Down Expand Up @@ -234,7 +235,12 @@ def umount_wait(self, force=False):

try:
if self.fuse_daemon:
self.fuse_daemon.wait()
# Permit a timeout, so that we do not block forever
run.wait([self.fuse_daemon], 900)
except MaxWhileTries:
log.error("process failed to terminate after unmount. This probably"
"indicates a bug within ceph-fuse.")
raise
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this actually do to the teuthology test runs that hit it? I've no idea but I think most throws in the post-yield cleanup result in hung jobs and nothing getting cleaned up...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gregsfortytwo in run_tasks.py, in the part following the "Unwinding manager..." log message, it looks to me like exceptions in teardown are explicitly handled.

Entirely possible for a rogue process to be left lying around, but that's why we have nuke

except CommandFailedError:
pass

Expand Down