Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
mds/quiesce: xlock the file to let clients keep their buffered writes
With the quiesce protocol taking a `rdlock` on the file, it also revokes the `Fb` capability, which the clients can't release until they are done flushing, and that may take up arbitrarily long, evidently, more than 10 minutes. We went for the rdlock to avoid affecting readonly clients, but given the evidence above we should not optimize for those. Ideally, we’d like to have a QUIESCE file lock mode where both rd and buffer are allowed, but as of now it seems like our best available option is to `xlock` the file which will let the writing clients keep their buffers for the duration of the quiesce. We can only afford this change for a `splitauth` config, i.e. where we drop the lock immediately after all `Fw`s are revoked Signed-off-by: Leonid Usov <leonid.usov@ibm.com> (cherry picked from commit 8ac9842) Fixes: https://tracker.ceph.com/issues/65556 Original-Issue: https://tracker.ceph.com/issues/65472 Original-PR: #56755
- Loading branch information