Skip to content

Commit

Permalink
mds: move MDS non-core dispatch into MDSRank
Browse files Browse the repository at this point in the history 
...along with all the supporting parts needed.  ms_verify etc
is still being done in MDS.

Signed-off-by: John Spray <john.spray@redhat.com>
  • Loading branch information
John Spray committed Jul 28, 2015
1 parent e54135c commit 2490a0a
Show file tree
Hide file tree
Showing 4 changed files with 810 additions and 797 deletions.

2 comments on commit 2490a0a

@cfanz
Copy link
Contributor

@cfanz cfanz commented on 2490a0a Aug 2, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, according to the comments for function bool MDSRank::_dispatch , shouldn't the function return a "true" on line 236, since the message has been put ?

@gregsfortytwo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment here is a little backwards; the point is that ms_dispatch (which directly calls this) expects a "true" to mean "I've handled this message", and returning true means we've taken away the message ref. But here, I think it shouldn't be calling put() at all, since it didn't take a reference and is disclaiming responsibility for it.

This probably hasn't caused trouble since an MDS shouldn't be getting Messages it doesn't recognize, but here's a PR changing it: #10533

Please sign in to comment.