Merge pull request #36733 from majianpeng/rocksdb-remove-redundant-pe…

…rfcount kv/RocksdbStore: remove perfcounter l_rocksdb_gets. Reviewed-by: Josh Durgin <jdurgin@redhat.com>
ceph · Sep 30, 2021 · 33bcd2e · 33bcd2e
2 parents d14580d + 2a4e96b
commit 33bcd2e
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 5 deletions.
diff --git a/src/kv/RocksDBStore.cc b/src/kv/RocksDBStore.cc
@@ -1199,7 +1199,6 @@ int RocksDBStore::do_open(ostream &out,
   ceph_assert(default_cf != nullptr);
 
   PerfCountersBuilder plb(cct, "rocksdb", l_rocksdb_first, l_rocksdb_last);
-  plb.add_u64_counter(l_rocksdb_gets, "get", "Gets");
   plb.add_time_avg(l_rocksdb_get_latency, "get_latency", "Get latency");
   plb.add_time_avg(l_rocksdb_submit_latency, "submit_latency", "Submit Latency");
   plb.add_time_avg(l_rocksdb_submit_sync_latency, "submit_sync_latency", "Submit Sync Latency");
@@ -1829,7 +1828,6 @@ int RocksDBStore::get(
     }
   }
   utime_t lat = ceph_clock_now() - start;
-  logger->inc(l_rocksdb_gets);
   logger->tinc(l_rocksdb_get_latency, lat);
   return 0;
 }
@@ -1865,7 +1863,6 @@ int RocksDBStore::get(
     ceph_abort_msg(s.getState());
   }
   utime_t lat = ceph_clock_now() - start;
-  logger->inc(l_rocksdb_gets);
   logger->tinc(l_rocksdb_get_latency, lat);
   return r;
 }
@@ -1903,7 +1900,6 @@ int RocksDBStore::get(
     ceph_abort_msg(s.getState());
   }
   utime_t lat = ceph_clock_now() - start;
-  logger->inc(l_rocksdb_gets);
   logger->tinc(l_rocksdb_get_latency, lat);
   return r;
 }

diff --git a/src/kv/RocksDBStore.h b/src/kv/RocksDBStore.h
@@ -31,7 +31,6 @@
 
 enum {
   l_rocksdb_first = 34300,
-  l_rocksdb_gets,
   l_rocksdb_get_latency,
   l_rocksdb_submit_latency,
   l_rocksdb_submit_sync_latency,