Skip to content

Commit

Permalink
rgw: Initializes uninitialized members of rgw
Browse files Browse the repository at this point in the history
Fixes the coverity issues:

** 1352181 Uninitialized scalar field
2. uninit_member: Non-static class member field fh_hk.bucket is
not initialized in this constructor nor in any functions that it calls.
CID 1352181 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
4. uninit_member: Non-static class member field fh_hk.object is
not initialized in this constructor nor in any functions that it calls.

** 1353424 Uninitialized scalar field
CID 1353424 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
5. uninit_member: Non-static class member watch_handle is not initialized
 in this constructor nor in any functions that it calls.

** 1355240 Uninitialized scalar field
CID 1355240 (#1 of 1): Uninitialized scalar field (UNINIT_CTOR)
2. uninit_member: Non-static class member index_type is not initialized
in this constructor nor in any functions that it calls.

Signed-off-by: Amit Kumar <amitkuma@redhat.com>
  • Loading branch information
amitkuma committed Aug 31, 2017
1 parent 6f00f9a commit 4bca8f8
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/rgw/rgw_common.h
Expand Up @@ -1197,7 +1197,7 @@ struct RGWBucketInfo
bool has_website;
RGWBucketWebsiteConf website_conf;

RGWBucketIndexType index_type;
RGWBucketIndexType index_type = RGWBIType_Normal;

bool swift_versioning;
string swift_ver_location;
Expand Down
2 changes: 1 addition & 1 deletion src/rgw/rgw_file.h
Expand Up @@ -91,7 +91,7 @@ namespace rgw {
*/
struct fh_key
{
rgw_fh_hk fh_hk;
rgw_fh_hk fh_hk {};
uint32_t version;

static constexpr uint64_t seed = 8675309;
Expand Down
2 changes: 1 addition & 1 deletion src/rgw/rgw_realm_watcher.h
Expand Up @@ -56,7 +56,7 @@ class RGWRealmWatcher : public librados::WatchCtx2 {
/// so that we don't miss notifications during realm reconfiguration
librados::Rados rados;
librados::IoCtx pool_ctx;
uint64_t watch_handle;
uint64_t watch_handle = 0;
std::string watch_oid;

int watch_start(RGWRealm& realm);
Expand Down

0 comments on commit 4bca8f8

Please sign in to comment.