mgr/dashboard: include in run-frontend-unittests.sh

Signed-off-by: Tiago Melo <tmelo@suse.com>
ceph · Nov 22, 2018 · 4c23bab · 4c23bab
1 parent 9565113
commit 4c23bab
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 24 deletions.
diff --git a/src/pybind/mgr/dashboard/HACKING.rst b/src/pybind/mgr/dashboard/HACKING.rst
@@ -249,9 +249,9 @@ parse the TypeScript files.
 When the command ran successfully, it should have created or updated the file
 ``src/locale/messages.xlf``.
 
-To make sure this file is always up to date in master branch, we have created a
-script ``run-frontend-i18n.sh`` that will fail if it finds uncommitted
-translations.
+To make sure this file is always up to date in master branch, we added a
+validation in ``run-frontend-unittests.sh`` that will fail if it finds
+uncommitted translations.
 
 Supported languages
 ~~~~~~~~~~~~~~~~~~~

diff --git a/src/pybind/mgr/dashboard/run-frontend-i18n.sh b/src/pybind/mgr/dashboard/run-frontend-i18n.sh
diff --git a/src/pybind/mgr/dashboard/run-frontend-unittests.sh b/src/pybind/mgr/dashboard/run-frontend-unittests.sh
@@ -32,6 +32,14 @@ if [ $? -gt 0 ]; then
 Some errors might need a manual fix."
 fi
 
+# I18N
+npm run i18n
+i18n_modified=`git status -s src/locale/messages.xlf`
+if [[ ! -z $i18n_modified ]]; then
+  echo  "Please run 'npm run i18n' and commit the modified 'messages.xlf' file."
+  failed=true
+fi
+
 if [ `uname` != "FreeBSD" ]; then
   deactivate
 fi