Merge pull request #16934 from amitkumar50/cov-librbd-2

librbd: Initializing members image,operation,journal Reviewed-by: Jason Dillaman <dillaman@redhat.com>
ceph · Aug 14, 2017 · 53e772a · 53e772a
2 parents 0a8ceaa + 233482c
commit 53e772a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/src/librbd/Journal.cc b/src/librbd/Journal.cc
@@ -64,7 +64,7 @@ struct C_IsTagOwner : public Context {
   Journaler *journaler;
   cls::journal::Client client;
   journal::ImageClientMeta client_meta;
-  uint64_t tag_tid;
+  uint64_t tag_tid = 0;
   journal::TagData tag_data;
 
   C_IsTagOwner(librados::IoCtx &io_ctx, const std::string &image_id,

diff --git a/src/librbd/image/CreateRequest.h b/src/librbd/image/CreateRequest.h
@@ -124,13 +124,13 @@ class CreateRequest {
   Context *m_on_finish;
 
   CephContext *m_cct;
-  int m_r_saved;  // used to return actual error after cleanup
+  int m_r_saved = 0;  // used to return actual error after cleanup
   bool m_force_non_primary;
   file_layout_t m_layout;
   std::string m_id_obj, m_header_obj, m_objmap_name;
 
   bufferlist m_outbl;
-  rbd_mirror_mode_t m_mirror_mode;
+  rbd_mirror_mode_t m_mirror_mode = RBD_MIRROR_MODE_DISABLED;
   cls::rbd::MirrorImage m_mirror_image_internal;
 
   void validate_pool();

diff --git a/src/librbd/image/RefreshRequest.h b/src/librbd/image/RefreshRequest.h
@@ -122,11 +122,11 @@ class RefreshRequest {
 
   bufferlist m_out_bl;
 
-  uint8_t m_order;
-  uint64_t m_size;
-  uint64_t m_features;
-  uint64_t m_incompatible_features;
-  uint64_t m_flags;
+  uint8_t m_order = 0;
+  uint64_t m_size = 0;
+  uint64_t m_features = 0;
+  uint64_t m_incompatible_features = 0;
+  uint64_t m_flags = 0;
   std::string m_object_prefix;
   ParentInfo m_parent_md;
   cls::rbd::GroupSpec m_group_spec;
@@ -143,7 +143,7 @@ class RefreshRequest {
   std::map<rados::cls::lock::locker_id_t,
            rados::cls::lock::locker_info_t> m_lockers;
   std::string m_lock_tag;
-  bool m_exclusive_locked;
+  bool m_exclusive_locked = false;
 
   bool m_blocked_writes = false;
   bool m_incomplete_update = false;