Skip to content

Commit

Permalink
mds: do not send split_realms for CEPH_SNAP_OP_UPDATE msg
Browse files Browse the repository at this point in the history
The clients won't care about the split_realms and the kclient will
treat this as a corrupted snaptrace.

Fixes commit 93e7267 ("mds: send snap
	related messages centrally during mds recovery")
Fixes: https://tracker.ceph.com/issues/61217
Signed-off-by: Xiubo Li <xiubli@redhat.com>
(cherry picked from commit 2131e1d)

Conflicts:
 - Misses a dependent commit 7a4c509
  • Loading branch information
lxbsz committed Aug 7, 2023
1 parent 43fa494 commit 600ed4f
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/mds/MDCache.cc
Expand Up @@ -6023,8 +6023,6 @@ void MDCache::finish_snaprealm_reconnect(client_t client, SnapRealm *realm, snap
<< realm->get_newest_seq() << " on " << *realm << dendl;
auto snap = make_message<MClientSnap>(CEPH_SNAP_OP_UPDATE);
snap->bl = realm->get_snap_trace();
for (const auto& child : realm->open_children)
snap->split_realms.push_back(child->inode->ino());
updates.emplace(std::piecewise_construct, std::forward_as_tuple(client), std::forward_as_tuple(snap));
} else {
dout(10) << "finish_snaprealm_reconnect client." << client << " up to date"
Expand Down

0 comments on commit 600ed4f

Please sign in to comment.