mgr/dashboard: Move services provision to service module

Few services were being declared in the shared module. Signed-off-by: Tiago Melo <tmelo@suse.com>
ceph · Apr 9, 2018 · 6420e7a · 6420e7a
1 parent 76ec342
commit 6420e7a
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 15 deletions.
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/app.module.ts b/src/pybind/mgr/dashboard/frontend/src/app/app.module.ts
@@ -30,15 +30,12 @@ export class CustomOption extends ToastOptions {
     BrowserAnimationsModule,
     ToastModule.forRoot(),
     AppRoutingModule,
-    HttpClientModule,
     CoreModule,
     SharedModule,
     CephModule,
     AccordionModule.forRoot(),
     BsDropdownModule.forRoot(),
-    TabsModule.forRoot(),
-    HttpClientModule,
-    BrowserAnimationsModule
+    TabsModule.forRoot()
   ],
   exports: [SharedModule],
   providers: [

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/services/services.module.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/services/services.module.ts
@@ -1,15 +1,19 @@
 import { CommonModule } from '@angular/common';
 import { NgModule } from '@angular/core';
 
+import { AuthGuardService } from './auth-guard.service';
+import { AuthStorageService } from './auth-storage.service';
 import { FormatterService } from './formatter.service';
 import { SummaryService } from './summary.service';
 
 @NgModule({
   imports: [CommonModule],
   declarations: [],
   providers: [
+    AuthGuardService,
+    AuthStorageService,
     FormatterService,
     SummaryService
   ]
 })
-export class ServicesModule { }
+export class ServicesModule {}
diff --git a/src/pybind/mgr/dashboard/frontend/src/app/shared/shared.module.ts b/src/pybind/mgr/dashboard/frontend/src/app/shared/shared.module.ts
@@ -7,9 +7,6 @@ import { DataTableModule } from './datatable/datatable.module';
 import { DimlessBinaryDirective } from './directives/dimless-binary.directive';
 import { PasswordButtonDirective } from './directives/password-button.directive';
 import { PipesModule } from './pipes/pipes.module';
-import { AuthGuardService } from './services/auth-guard.service';
-import { AuthStorageService } from './services/auth-storage.service';
-import { FormatterService } from './services/formatter.service';
 import { ServicesModule } from './services/services.module';
 
 @NgModule({
@@ -31,12 +28,8 @@ import { ServicesModule } from './services/services.module';
     ServicesModule,
     PasswordButtonDirective,
     DimlessBinaryDirective,
-    DataTableModule
-  ],
-  providers: [
-    AuthStorageService,
-    AuthGuardService,
-    FormatterService,
-  ],
+    DataTableModule,
+    ApiModule
+  ]
 })
 export class SharedModule {}