Skip to content

Commit

Permalink
mgr: quieten logging on missing OSD stats
Browse files Browse the repository at this point in the history
This is only cause for concern if the OSD is actually up,
and even then it can also happen at startup, so
we shouldn't be logging it as an error.

Fixes: https://tracker.ceph.com/issues/23017
Signed-off-by: John Spray <john.spray@redhat.com>
(cherry picked from commit b6b2b07)
  • Loading branch information
John Spray authored and Prashant D committed Mar 27, 2018
1 parent 9622def commit 686dff7
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/mon/PGMap.cc
Expand Up @@ -917,7 +917,11 @@ int64_t PGMap::get_rule_avail(const OSDMap& osdmap, int ruleno) const
min = proj;
}
} else {
dout(0) << "Cannot get stat of OSD " << p->first << dendl;
if (osdmap.is_up(p->first)) {
// This is a level 4 rather than an error, because we might have
// only just started, and not received the first stats message yet.
dout(4) << "OSD " << p->first << " is up, but has no stats" << dendl;
}
}
}
return min;
Expand Down

0 comments on commit 686dff7

Please sign in to comment.