mgr/dashboard: Consider user permissions

Consider user permissions when showing advanced table actions and hide all buttons requiring missing permissions from the user. Also consider user permissions when showing submit buttons. Signed-off-by: Tatjana Dehler <tdehler@suse.com> (cherry picked from commit aa68aca)
ceph · Jun 14, 2019 · 7384e4c · 7384e4c
1 parent e78c7a4
commit 7384e4c
Show file tree

Hide file tree

Showing 8 changed files with 61 additions and 19 deletions.
diff --git a/...ashboard/frontend/src/app/ceph/cluster/osd/osd-flags-modal/osd-flags-modal.component.html b/...ashboard/frontend/src/app/ceph/cluster/osd/osd-flags-modal/osd-flags-modal.component.html
@@ -29,7 +29,8 @@
 
       <div class="modal-footer">
         <div class="button-group text-right">
-          <cd-submit-button (submitAction)="submitAction()"
+          <cd-submit-button *ngIf="permissions.osd.update"
+                            (submitAction)="submitAction()"
                             [form]="osdFlagsForm"
                             i18n>Submit</cd-submit-button>
           <cd-back-button [back]="bsModalRef.hide"

diff --git a/.../dashboard/frontend/src/app/ceph/cluster/osd/osd-flags-modal/osd-flags-modal.component.ts b/.../dashboard/frontend/src/app/ceph/cluster/osd/osd-flags-modal/osd-flags-modal.component.ts
@@ -7,6 +7,8 @@ import { BsModalRef } from 'ngx-bootstrap/modal';
 
 import { OsdService } from '../../../../shared/api/osd.service';
 import { NotificationType } from '../../../../shared/enum/notification-type.enum';
+import { Permissions } from '../../../../shared/models/permissions';
+import { AuthStorageService } from '../../../../shared/services/auth-storage.service';
 import { NotificationService } from '../../../../shared/services/notification.service';
 
 @Component({
@@ -15,6 +17,8 @@ import { NotificationService } from '../../../../shared/services/notification.se
   styleUrls: ['./osd-flags-modal.component.scss']
 })
 export class OsdFlagsModalComponent implements OnInit {
+  permissions: Permissions;
+
   osdFlagsForm = new FormGroup({});
 
   allFlags = {
@@ -112,10 +116,13 @@ export class OsdFlagsModalComponent implements OnInit {
 
   constructor(
     public bsModalRef: BsModalRef,
+    private authStorageService: AuthStorageService,
     private osdService: OsdService,
     private notificationService: NotificationService,
     private i18n: I18n
-  ) {}
+  ) {
+    this.permissions = this.authStorageService.getPermissions();
+  }
 
   ngOnInit() {
     this.osdService.getFlags().subscribe((res: string[]) => {

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-list/osd-list.component.html b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-list/osd-list.component.html
@@ -15,24 +15,23 @@
         </cd-table-actions>
 
         <div class="btn-group"
-             dropdown>
+             dropdown
+             *ngIf="advancedTableActions.length > 0">
           <button type="button"
                   class="btn btn-sm btn-default btn-label tc_configureCluster"
-                  (click)="configureClusterAction()">
-            <i class="fa fa-fw fa-cog"
-               aria-hidden="true">
-            </i>
-            <ng-container i18n>Set Cluster-wide Flags</ng-container>
+                  (click)="advancedTableActions[0].click()">
+            <i class="fa fa-fw {{ advancedTableActions[0].icon }}"></i><span>{{ advancedTableActions[0].name }}</span>
           </button>
           <button type="button"
                   dropdownToggle
-                  class="btn btn-sm btn-default dropdown-toggle dropdown-toggle-split">
+                  class="btn btn-sm btn-default dropdown-toggle dropdown-toggle-split"
+                  *ngIf="advancedTableActions.length > 1">
             <span class="caret caret-black"></span>
           </button>
           <ul *dropdownMenu
               class="dropdown-menu"
               role="menu">
-            <ng-container *ngFor="let action of generalTableActions">
+            <ng-container *ngFor="let action of advancedTableActions | slice:1">
               <li role="menuitem">
                 <a class="dropdown-item"
                    (click)="action.click()">

diff --git a/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-list/osd-list.component.ts b/src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-list/osd-list.component.ts
@@ -46,7 +46,7 @@ export class OsdListComponent implements OnInit {
   tableActions: CdTableAction[];
   bsModalRef: BsModalRef;
   columns: CdTableColumn[];
-  generalTableActions: any[];
+  advancedTableActions: any[];
 
   osds = [];
   selection = new CdTableSelection();
@@ -146,16 +146,24 @@ export class OsdListComponent implements OnInit {
         icon: 'fa-remove'
       }
     ];
-    this.generalTableActions = [
+    this.advancedTableActions = [
       {
-        name: this.i18n('Set Cluster-wide Recovery Priority'),
+        name: this.i18n('Cluster-wide Flags'),
+        icon: 'fa-flag',
+        click: () => this.configureFlagsAction(),
+        permission: this.permissions.osd.read
+      },
+      {
+        name: this.i18n('Cluster-wide Recovery Priority'),
         icon: 'fa-cog',
-        click: () => this.configureQosParamsAction()
+        click: () => this.configureQosParamsAction(),
+        permission: this.permissions.configOpt.read
       },
       {
-        name: this.i18n('PG scrub configuration'),
+        name: this.i18n('PG scrub'),
         icon: 'fa-stethoscope',
-        click: () => this.configurePgScrubAction()
+        click: () => this.configurePgScrubAction(),
+        permission: this.permissions.configOpt.read
       }
     ];
   }
@@ -189,6 +197,8 @@ export class OsdListComponent implements OnInit {
         cellTransformation: CellTemplate.perSecond
       }
     ];
+
+    this.removeActionsWithNoPermissions();
   }
 
   get hasOsdSelected() {
@@ -259,7 +269,7 @@ export class OsdListComponent implements OnInit {
     this.bsModalRef = this.modalService.show(OsdScrubModalComponent, { initialState });
   }
 
-  configureClusterAction() {
+  configureFlagsAction() {
     this.bsModalRef = this.modalService.show(OsdFlagsModalComponent, {});
   }
 
@@ -324,4 +334,16 @@ export class OsdListComponent implements OnInit {
   configurePgScrubAction() {
     this.bsModalRef = this.modalService.show(OsdPgScrubModalComponent, { class: 'modal-lg' });
   }
+
+  /**
+   * Removes all actions from 'advancedTableActions' that need a permission the user doesn't have.
+   */
+  private removeActionsWithNoPermissions() {
+    if (!this.permissions) {
+      this.advancedTableActions = [];
+      return;
+    }
+
+    this.advancedTableActions = this.advancedTableActions.filter((action) => action.permission);
+  }
 }
diff --git a/...rd/frontend/src/app/ceph/cluster/osd/osd-pg-scrub-modal/osd-pg-scrub-modal.component.html b/...rd/frontend/src/app/ceph/cluster/osd/osd-pg-scrub-modal/osd-pg-scrub-modal.component.html
@@ -35,7 +35,8 @@
       </div>
       <div class="modal-footer">
         <div class="button-group text-right">
-          <cd-submit-button (submitAction)="submitAction()"
+          <cd-submit-button *ngIf="permissions.configOpt.update"
+                            (submitAction)="submitAction()"
                             [form]="osdPgScrubForm"
                             i18n="form action button|Example: Create Pool@@formActionButton"
                             type="button">{{ action | titlecase }} {{ resource | upperFirst }}</cd-submit-button>

diff --git a/...oard/frontend/src/app/ceph/cluster/osd/osd-pg-scrub-modal/osd-pg-scrub-modal.component.ts b/...oard/frontend/src/app/ceph/cluster/osd/osd-pg-scrub-modal/osd-pg-scrub-modal.component.ts
@@ -8,6 +8,8 @@ import { ConfigOptionComponent } from '../../../../shared/components/config-opti
 import { ActionLabelsI18n } from '../../../../shared/constants/app.constants';
 import { NotificationType } from '../../../../shared/enum/notification-type.enum';
 import { CdFormGroup } from '../../../../shared/forms/cd-form-group';
+import { Permissions } from '../../../../shared/models/permissions';
+import { AuthStorageService } from '../../../../shared/services/auth-storage.service';
 import { NotificationService } from '../../../../shared/services/notification.service';
 import { OsdPgScrubModalOptions } from './osd-pg-scrub-modal.options';
 
@@ -20,6 +22,7 @@ export class OsdPgScrubModalComponent {
   osdPgScrubForm: CdFormGroup;
   action: string;
   resource: string;
+  permissions: Permissions;
 
   @ViewChild('basicOptionsValues')
   basicOptionsValues: ConfigOptionComponent;
@@ -33,13 +36,15 @@ export class OsdPgScrubModalComponent {
 
   constructor(
     public bsModalRef: BsModalRef,
+    private authStorageService: AuthStorageService,
     private notificationService: NotificationService,
     private i18n: I18n,
     public actionLabels: ActionLabelsI18n
   ) {
     this.osdPgScrubForm = new CdFormGroup({});
     this.resource = this.i18n('PG scrub options');
     this.action = this.actionLabels.EDIT;
+    this.permissions = this.authStorageService.getPermissions();
   }
 
   submitAction() {

diff --git a/...rontend/src/app/ceph/cluster/osd/osd-recv-speed-modal/osd-recv-speed-modal.component.html b/...rontend/src/app/ceph/cluster/osd/osd-recv-speed-modal/osd-recv-speed-modal.component.html
@@ -82,7 +82,8 @@
       </div>
       <div class="modal-footer">
         <div class="button-group text-right">
-          <cd-submit-button (submitAction)="submitAction()"
+          <cd-submit-button *ngIf="permissions.configOpt.update"
+                            (submitAction)="submitAction()"
                             [form]="osdRecvSpeedForm"
                             i18n>Submit</cd-submit-button>
           <cd-back-button [back]="bsModalRef.hide"

diff --git a/.../frontend/src/app/ceph/cluster/osd/osd-recv-speed-modal/osd-recv-speed-modal.component.ts b/.../frontend/src/app/ceph/cluster/osd/osd-recv-speed-modal/osd-recv-speed-modal.component.ts
@@ -10,6 +10,8 @@ import { OsdService } from '../../../../shared/api/osd.service';
 import { ConfigOptionTypes } from '../../../../shared/components/config-option/config-option.types';
 import { NotificationType } from '../../../../shared/enum/notification-type.enum';
 import { CdFormGroup } from '../../../../shared/forms/cd-form-group';
+import { Permissions } from '../../../../shared/models/permissions';
+import { AuthStorageService } from '../../../../shared/services/auth-storage.service';
 import { NotificationService } from '../../../../shared/services/notification.service';
 
 @Component({
@@ -19,16 +21,20 @@ import { NotificationService } from '../../../../shared/services/notification.se
 })
 export class OsdRecvSpeedModalComponent implements OnInit {
   osdRecvSpeedForm: CdFormGroup;
+  permissions: Permissions;
+
   priorities = [];
   priorityAttrs = {};
 
   constructor(
     public bsModalRef: BsModalRef,
+    private authStorageService: AuthStorageService,
     private configService: ConfigurationService,
     private notificationService: NotificationService,
     private i18n: I18n,
     private osdService: OsdService
   ) {
+    this.permissions = this.authStorageService.getPermissions();
     this.priorities = this.osdService.osdRecvSpeedModalPriorities.KNOWN_PRIORITIES;
     this.osdRecvSpeedForm = new CdFormGroup({
       priority: new FormControl(null, { validators: [Validators.required] }),