Skip to content

Commit

Permalink
mds: do not log internal journal error
Browse files Browse the repository at this point in the history
MDS can't reach this code due to assert in C_MDS_session_finish.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
(cherry picked from commit 0992ac1)

Conflicts:
	src/mds/Server.cc
  • Loading branch information
batrick committed Feb 3, 2019
1 parent 120d6a2 commit 7b13497
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions src/mds/Server.cc
Expand Up @@ -436,13 +436,8 @@ void Server::handle_client_session(MClientSession *m)
sseq = mds->sessionmap.set_state(session, Session::STATE_OPENING);
mds->sessionmap.touch_session(session);
auto fin = new FunctionContext([log_session_status = std::move(log_session_status)](int r){
if (r == 0) {
log_session_status("ACCEPTED", "");
} else {
std::stringstream ss;
ss << "(internal) r = " << r;
log_session_status("REJECTED", ss.str());
}
assert(r == 0);
log_session_status("ACCEPTED", "");
});
mdlog->start_submit_entry(new ESession(m->get_source_inst(), true, pv, client_metadata),
new C_MDS_session_finish(this, session, sseq, true, pv, fin));
Expand Down

0 comments on commit 7b13497

Please sign in to comment.