include: codify the ownership change of the map

Caller must explicitly std::move it. Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
ceph · Dec 16, 2019 · 7c53a69 · 7c53a69
1 parent 817cc50
commit 7c53a69
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/src/include/interval_set.h b/src/include/interval_set.h
@@ -160,7 +160,7 @@ class interval_set {
   };
 
   interval_set() : _size(0) {}
-  interval_set(Map& other) {
+  interval_set(Map&& other) {
     m.swap(other);
     _size = 0;
     for (auto& i : m) {

diff --git a/src/osd/PGBackend.h b/src/osd/PGBackend.h
@@ -565,7 +565,7 @@ typedef std::shared_ptr<const OSDMap> OSDMapRef;
 
    virtual int objects_readv_sync(
      const hobject_t &hoid,
-     map<uint64_t, uint64_t>& m,
+     map<uint64_t, uint64_t>&& m,
      uint32_t op_flags,
      bufferlist *bl) {
      return -EOPNOTSUPP;

diff --git a/src/osd/PrimaryLogPG.cc b/src/osd/PrimaryLogPG.cc
@@ -5574,7 +5574,7 @@ int PrimaryLogPG::do_sparse_read(OpContext *ctx, OSDOp& osd_op) {
     }
 
     bufferlist data_bl;
-    r = pgbackend->objects_readv_sync(soid, m, op.flags, &data_bl);
+    r = pgbackend->objects_readv_sync(soid, std::move(m), op.flags, &data_bl);
     if (r == -EIO) {
       r = rep_repair_primary_object(soid, ctx);
     }

diff --git a/src/osd/ReplicatedBackend.cc b/src/osd/ReplicatedBackend.cc
@@ -257,11 +257,11 @@ int ReplicatedBackend::objects_read_sync(
 
 int ReplicatedBackend::objects_readv_sync(
   const hobject_t &hoid,
-  map<uint64_t, uint64_t>& m,
+  map<uint64_t, uint64_t>&& m,
   uint32_t op_flags,
   bufferlist *bl)
 {
-  interval_set<uint64_t> im(m);
+  interval_set<uint64_t> im(std::move(m));
   auto r = store->readv(ch, ghobject_t(hoid), im, *bl, op_flags);
   if (r >= 0) {
     m = std::move(im).detach();
@@ -2081,7 +2081,7 @@ int ReplicatedBackend::build_push_op(const ObjectRecoveryInfo &recovery_info,
       int r = store->fiemap(ch, ghobject_t(recovery_info.soid), 0,
                             copy_subset.range_end(), m);
       if (r >= 0)  {
-        interval_set<uint64_t> fiemap_included(m);
+        interval_set<uint64_t> fiemap_included(std::move(m));
         copy_subset.intersection_of(fiemap_included);
       } else {
         // intersection of copy_subset and empty interval_set would be empty anyway

diff --git a/src/osd/ReplicatedBackend.h b/src/osd/ReplicatedBackend.h
@@ -151,7 +151,7 @@ class ReplicatedBackend : public PGBackend {
 
   int objects_readv_sync(
     const hobject_t &hoid,
-    map<uint64_t, uint64_t>& m,
+    map<uint64_t, uint64_t>&& m,
     uint32_t op_flags,
     bufferlist *bl) override;