-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
common: ceph_ioprio_string_to_class always returns -EINVAL
The l string is always empty because std::transform needs a pre-allocated string. Replace with the in-place version. Add unit tests. http://tracker.ceph.com/issues/9677 Fixes: #9677 Signed-off-by: Loic Dachary <loic-201408@dachary.org> (cherry picked from commit 3535b7a) Conflicts: src/test/Makefile.am
- Loading branch information
Loic Dachary
committed
Oct 7, 2014
1 parent
5f2eec5
commit 86926c6
Showing
3 changed files
with
60 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
// -*- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*- | ||
// vim: ts=8 sw=2 smarttab | ||
/* | ||
* Ceph - scalable distributed file system | ||
* | ||
* Copyright (C) 2014 Red Hat <contact@redhat.com> | ||
* | ||
* Author: Loic Dachary <loic@dachary.org> | ||
* | ||
* This library is free software; you can redistribute it and/or | ||
* modify it under the terms of the GNU Lesser General Public | ||
* License as published by the Free Software Foundation; either | ||
* version 2.1 of the License, or (at your option) any later version. | ||
* | ||
*/ | ||
|
||
#include <errno.h> | ||
#include <gtest/gtest.h> | ||
|
||
#include "common/io_priority.h" | ||
|
||
TEST(io_priority, ceph_ioprio_string_to_class) { | ||
ASSERT_EQ(IOPRIO_CLASS_IDLE, ceph_ioprio_string_to_class("idle")); | ||
ASSERT_EQ(IOPRIO_CLASS_IDLE, ceph_ioprio_string_to_class("IDLE")); | ||
|
||
ASSERT_EQ(IOPRIO_CLASS_BE, ceph_ioprio_string_to_class("be")); | ||
ASSERT_EQ(IOPRIO_CLASS_BE, ceph_ioprio_string_to_class("BE")); | ||
ASSERT_EQ(IOPRIO_CLASS_BE, ceph_ioprio_string_to_class("besteffort")); | ||
ASSERT_EQ(IOPRIO_CLASS_BE, ceph_ioprio_string_to_class("BESTEFFORT")); | ||
ASSERT_EQ(IOPRIO_CLASS_BE, ceph_ioprio_string_to_class("best effort")); | ||
ASSERT_EQ(IOPRIO_CLASS_BE, ceph_ioprio_string_to_class("BEST EFFORT")); | ||
|
||
ASSERT_EQ(IOPRIO_CLASS_RT, ceph_ioprio_string_to_class("rt")); | ||
ASSERT_EQ(IOPRIO_CLASS_RT, ceph_ioprio_string_to_class("RT")); | ||
ASSERT_EQ(IOPRIO_CLASS_RT, ceph_ioprio_string_to_class("realtime")); | ||
ASSERT_EQ(IOPRIO_CLASS_RT, ceph_ioprio_string_to_class("REALTIME")); | ||
ASSERT_EQ(IOPRIO_CLASS_RT, ceph_ioprio_string_to_class("real time")); | ||
ASSERT_EQ(IOPRIO_CLASS_RT, ceph_ioprio_string_to_class("REAL TIME")); | ||
|
||
ASSERT_EQ(-EINVAL, ceph_ioprio_string_to_class("invalid")); | ||
} | ||
|
||
/* | ||
* Local Variables: | ||
* compile-command: "cd ../.. ; | ||
* make -j4 unittest_io_priority && | ||
* libtool --mode=execute valgrind --tool=memcheck --leak-check=full \ | ||
* ./unittest_io_priority | ||
* " | ||
* End: | ||
*/ |