Skip to content

Commit

Permalink
ceph-disk: fix Error() messages formatting
Browse files Browse the repository at this point in the history
Mainly using % instead of ,

Signed-off-by: Loic Dachary <loic@dachary.org>
  • Loading branch information
Loic Dachary committed Jan 3, 2014
1 parent 6b8d418 commit b82ccfb
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions src/ceph-disk
Expand Up @@ -514,7 +514,7 @@ def check_osd_id(osd_id):
Ensures osd id is numeric.
"""
if not re.match(r'^[0-9]+$', osd_id):
raise Error('osd id is not numeric')
raise Error('osd id is not numeric', osd_id)


def allocate_osd_id(
Expand Down Expand Up @@ -1013,7 +1013,7 @@ def prepare_journal(
raise Error('Journal is not a regular file', journal)
return prepare_journal_dev(data, journal, journal_size, journal_uuid, journal_dm_keypath)

raise Error('Journal %s is neither a block device nor regular file', journal)
raise Error('Journal %s is neither a block device nor regular file' % journal)


def adjust_symlink(target, path):
Expand Down Expand Up @@ -1808,7 +1808,7 @@ def main_activate(args):
osd_id = None

if not os.path.exists(args.path):
raise Error('%s does not exist', args.path)
raise Error('%s does not exist' % args.path)

if is_suppressed(args.path):
LOG.info('suppressed activate request on %s', args.path)
Expand All @@ -1830,7 +1830,7 @@ def main_activate(args):
init=args.mark_init,
)
else:
raise Error('%s is not a directory or block device', args.path)
raise Error('%s is not a directory or block device' % args.path)

start_daemon(
cluster=cluster,
Expand All @@ -1846,11 +1846,11 @@ def main_activate(args):

def get_journal_osd_uuid(path):
if not os.path.exists(path):
raise Error('%s does not exist', path)
raise Error('%s does not exist' % path)

mode = os.stat(path).st_mode
if not stat.S_ISBLK(mode):
raise Error('%s is not a block device', path)
raise Error('%s is not a block device' % path)

try:
out = _check_output(
Expand All @@ -1874,7 +1874,7 @@ def get_journal_osd_uuid(path):

def main_activate_journal(args):
if not os.path.exists(args.dev):
raise Error('%s does not exist', args.dev)
raise Error('%s does not exist' % args.dev)

cluster = None
osd_id = None
Expand Down

0 comments on commit b82ccfb

Please sign in to comment.