Skip to content

Commit

Permalink
ceph.spec.in: remove build directory in %clean, not %install
Browse files Browse the repository at this point in the history
Removing the build directory at the end of %install is too soon,
and means we get rid of a bunch of stuff needed to correctly
create debuginfo/debugsource packages, which happens automatically
right after %install.  So, let's put it where it really belongs, in
the %clean section.

Fixes: aa18cb1
Fixes: https://tracker.ceph.com/issues/55079
Signed-off-by: Tim Serong <tserong@suse.com>
(cherry picked from commit 94ad178)
  • Loading branch information
tserong committed May 26, 2022
1 parent ca6c6f3 commit bba2708
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions ceph.spec.in
Original file line number Diff line number Diff line change
Expand Up @@ -1356,13 +1356,12 @@ install -m 644 -D monitoring/prometheus/alerts/ceph_default_alerts.yml %{buildro
%py_byte_compile %{__python3} %{buildroot}%{python3_sitelib}
%endif

%clean
rm -rf %{buildroot}
# built binaries are no longer necessary at this point,
# but are consuming ~17GB of disk in the build environment
rm -rf build

%clean
rm -rf %{buildroot}

#################################################################################
# files and systemd scriptlets
#################################################################################
Expand Down

0 comments on commit bba2708

Please sign in to comment.