Skip to content

Commit

Permalink
SimpleMessenger: allow RESETSESSION whenever we forget an endpoint
Browse files Browse the repository at this point in the history
In the past (e229f84) we decided to disable
reset of lossless Pipes, because lossless peers resetting caused trouble and
they can't forget about each other. But they actually can: if mark_down()
is called.

I can't figure out how else we could forget about a remote endpoint, so I think
it's okay if we tell them we reset in order to clean up state. That's desirable
so that we don't get into strange situations with out-of-whack counters.

Fixes: #10080

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
  • Loading branch information
gregsfortytwo committed Dec 2, 2014
1 parent 56dae09 commit bbd4b88
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/msg/simple/Pipe.cc
Expand Up @@ -597,7 +597,7 @@ int Pipe::accept()
<< " > " << existing->connect_seq << dendl;
goto replace;
} // existing
else if (policy.resetcheck && connect.connect_seq > 0) {
else if (connect.connect_seq > 0) {
// we reset, and they are opening a new session
ldout(msgr->cct,0) << "accept we reset (peer sent cseq " << connect.connect_seq << "), sending RESETSESSION" << dendl;
msgr->lock.Unlock();
Expand Down

0 comments on commit bbd4b88

Please sign in to comment.