Skip to content

Commit

Permalink
cephfs: add additional logging to track change_attr of inodes
Browse files Browse the repository at this point in the history
Signed-off-by: Ramana Raja <rraja@redhat.com>
  • Loading branch information
ajarr committed Oct 14, 2022
1 parent 05fdd6c commit f02b777
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 3 deletions.
3 changes: 2 additions & 1 deletion src/client/Client.cc
Expand Up @@ -1108,6 +1108,7 @@ Inode * Client::add_update_inode(InodeStat *st, utime_t from,
}

/* always take a newer change attr */
ldout(cct, 12) << __func__ << " client inode change_attr: " << in->change_attr << " , mds inodestat change_attr: " << st->change_attr << dendl;
if (st->change_attr > in->change_attr)
in->change_attr = st->change_attr;

Expand Down Expand Up @@ -8334,7 +8335,7 @@ void Client::fill_statx(Inode *in, unsigned int mask, struct ceph_statx *stx)
{
ldout(cct, 10) << __func__ << " on " << in->ino << " snap/dev" << in->snapid
<< " mode 0" << oct << in->mode << dec
<< " mtime " << in->mtime << " ctime " << in->ctime << dendl;
<< " mtime " << in->mtime << " ctime " << in->ctime << " change_attr " << in->change_attr << dendl;
memset(stx, 0, sizeof(struct ceph_statx));

/*
Expand Down
1 change: 1 addition & 0 deletions src/client/Inode.cc
Expand Up @@ -56,6 +56,7 @@ ostream& operator<<(ostream &out, const Inode &in)
<< " btime=" << in.btime
<< " mtime=" << in.mtime
<< " ctime=" << in.ctime
<< " change_attr=" << in.change_attr
<< " caps=" << ccap_string(in.caps_issued());
if (!in.caps.empty()) {
out << "(";
Expand Down
4 changes: 3 additions & 1 deletion src/mds/CInode.cc
Expand Up @@ -3800,7 +3800,9 @@ int CInode::encode_inodestat(bufferlist& bl, Session *session,
dout(20) << " pfile " << pfile << " pauth " << pauth
<< " plink " << plink << " pxattr " << pxattr
<< " plocal " << plocal
<< " mtime " << any_i->mtime
<< " ctime " << any_i->ctime
<< " change_attr " << any_i->change_attr
<< " valid=" << valid << dendl;

// file
Expand Down Expand Up @@ -4148,7 +4150,7 @@ void CInode::encode_cap_message(const ref_t<MClientCaps> &m, Capability *cap)

dout(20) << __func__ << " pfile " << pfile
<< " pauth " << pauth << " plink " << plink << " pxattr " << pxattr
<< " ctime " << i->ctime << dendl;
<< " mtime " << i->mtime << " ctime " << i->ctime << " change_attr " << i->change_attr << dendl;

i = pfile ? pi:oi;
m->set_layout(i->layout);
Expand Down
4 changes: 3 additions & 1 deletion src/messages/MClientCaps.h
Expand Up @@ -194,7 +194,9 @@ class MClientCaps final : public SafeMessage {
out << " size " << size << "/" << max_size;
if (truncate_seq)
out << " ts " << truncate_seq << "/" << truncate_size;
out << " mtime " << mtime;
out << " mtime " << mtime
<< " ctime " << ctime
<< " change_attr " << change_attr;
if (time_warp_seq)
out << " tws " << time_warp_seq;

Expand Down

0 comments on commit f02b777

Please sign in to comment.