suites: remove extra filestore_debug.. config that left

Extra un needed checks and sets for filestore in suites setup need to be removed. Signed-off-by: Nitzan Mordechai <nmordech@redhat.com>
ceph · Sep 7, 2023 · f78ba83 · f78ba83
1 parent 848a6c9
commit f78ba83
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 15 deletions.
diff --git a/qa/suites/rados/singleton/all/random-eio.yaml b/qa/suites/rados/singleton/all/random-eio.yaml
@@ -28,7 +28,6 @@ tasks:
 - full_sequential:
   - exec:
       client.0:
-        - sudo ceph tell osd.1 injectargs -- --filestore_debug_random_read_err=0.33
         - sudo ceph tell osd.1 injectargs -- --bluestore_debug_random_read_err=0.33
         - sudo ceph osd pool create test 16 16
         - sudo ceph osd pool set test size 3
@@ -42,5 +41,4 @@ tasks:
       create_pool: false
   - exec:
       client.0:
-        - sudo ceph tell osd.1 injectargs -- --filestore_debug_random_read_err=0.0
         - sudo ceph tell osd.1 injectargs -- --bluestore_debug_random_read_err=0.0
diff --git a/qa/tasks/ceph_manager.py b/qa/tasks/ceph_manager.py
@@ -562,8 +562,6 @@ def revive_osd(self, osd=None, skip_admin_check=False):
         self.dead_osds.remove(osd)
         self.live_osds.append(osd)
         if self.random_eio > 0 and osd == self.rerrosd:
-            self.ceph_manager.set_config(self.rerrosd,
-                                         filestore_debug_random_read_err = self.random_eio)
             self.ceph_manager.set_config(self.rerrosd,
                                          bluestore_debug_random_read_err = self.random_eio)
 
@@ -1366,9 +1364,6 @@ def _do_thrash(self):
         delay = self.config.get("op_delay", 5)
         self.rerrosd = self.live_osds[0]
         if self.random_eio > 0:
-            self.ceph_manager.inject_args('osd', self.rerrosd,
-                                          'filestore_debug_random_read_err',
-                                          self.random_eio)
             self.ceph_manager.inject_args('osd', self.rerrosd,
                                           'bluestore_debug_random_read_err',
                                           self.random_eio)
@@ -1402,8 +1397,6 @@ def _do_thrash(self):
             time.sleep(delay)
         self.all_up()
         if self.random_eio > 0:
-            self.ceph_manager.inject_args('osd', self.rerrosd,
-                                          'filestore_debug_random_read_err', '0.0')
             self.ceph_manager.inject_args('osd', self.rerrosd,
                                           'bluestore_debug_random_read_err', '0.0')
         for pool in list(self.pools_to_fix_pgp_num):

diff --git a/src/common/options/global.yaml.in b/src/common/options/global.yaml.in
@@ -5640,12 +5640,6 @@ options:
   level: dev
   default: false
   with_legacy: true
-- name: filestore_debug_random_read_err
-  type: float
-  level: dev
-  default: 0
-  with_legacy: true
-# Expensive debugging check on sync
 - name: filestore_debug_omap_check
   type: bool
   level: dev