fix #5426 race in librbd #1000
Merged
fix #5426 race in librbd #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The perfcounters (and the ictx) are only valid while the image is still open. If the librbd user gets the callback for its last I/O, then closes the image, the ictx and its perfcounters will be invalid. If the AioCompletion object is has not run the rest of its complete() method yet, it will access these now-invalid addresses, possibly leading to a crash. The AioCompletion object is independent of the ictx and does not access it again after incrementing perfcounters, so avoid this race by calling the user's callback after this step. The AioCompletion object will be cleaned up by the rest of complete_request(), independent of the ImageCtx. Fixes: #5426 Backport: dumpling, emperor Signed-off-by: Josh Durgin <josh.durgin@inktank.com>
|
aie.. so simple in retrospect! |
|
reviewed-by |
jdurgin
added a commit
that referenced
this pull request
Dec 27, 2013
fix #5426 race in librbd Reviewed-by: Sage Weil <sage@inktank.com>
liewegas
pushed a commit
to liewegas/ceph
that referenced
this pull request
Nov 18, 2016
make-rpm.sh: support openSUSE Reviewed-by: Loic Dachary <ldachary@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.