Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] (cherry picked from commit 85bb43e111692989d2296a389ce45377d2297d6f) #10079

Closed
wants to merge 1 commit into from
Closed

[DNM] (cherry picked from commit 85bb43e111692989d2296a389ce45377d2297d6f) #10079

wants to merge 1 commit into from

Conversation

diluga
Copy link
Contributor

@diluga diluga commented Jul 1, 2016

RGW: add socket backlog setting for via ceph.conf
http://tracker.ceph.com/issues/16436
Signed-off-by: Feng Guo diluga@gmail.com

RGW: add socket backlog setting for via ceph.conf
http://tracker.ceph.com/issues/16436
Signed-off-by: Feng Guo <diluga@gmail.com>
@tchaikov
Copy link
Contributor

tchaikov commented Jul 8, 2016

should "cherry-pick -x 3e4df83". please fix your commit message and its title.

@tchaikov tchaikov changed the title (cherry picked from commit 85bb43e111692989d2296a389ce45377d2297d6f) [DNM] (cherry picked from commit 85bb43e111692989d2296a389ce45377d2297d6f) Jul 8, 2016
@tchaikov tchaikov added this to the hammer milestone Jul 8, 2016
@smithfarm
Copy link
Contributor

smithfarm commented Jul 8, 2016

@yehudasa OK to backport this feature to jewel and hammer?

@smithfarm
Copy link
Contributor

The master PR is #9891

@yehudasa
Copy link
Member

yehudasa commented Jul 8, 2016

@smithfarm fine with me

@smithfarm
Copy link
Contributor

@diluga As @tchaikov wrote, the command is git cherry-pick -x 3e4df83 - you are trying to cherry-pick 85bb43e which is the merge commit. That will not work. Once you cherry-pick the correct commit, you will not need to modify the commit message at all, except as described below.

Here is a more detailed HOWTO:

  1. checkout the latest hammer branch
  2. git checkout -b wip-16436-hammer
  3. git cherry-pick -x 3e4df83 <- don't modify the commit message unless there are conflict(s). If there are conflicts, just append a brief description of how you resolved the conflict(s).
  4. git push -u origin wip-16436-hammer
  5. open PR against hammer

Hope this helps, and thanks for contributing!

@smithfarm smithfarm self-assigned this Jul 8, 2016
@smithfarm
Copy link
Contributor

@diluga I staged the jewel backport at #10216 if you want to look.

@diluga
Copy link
Contributor Author

diluga commented Jul 9, 2016

@smithfarm thx,a lot! i followed with your guide,and the new PR: #10219

@tchaikov tchaikov closed this Jul 9, 2016
@smithfarm
Copy link
Contributor

@diluga You're welcome! I looked at the commit message in #10219 and there is no description of how the conflicts were resolved. Anyway, don't do anything more until we clarify whether this feature is eligible for backport to hammer at all - it looks like it depends on c52a9fa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants