cmake: remove WITH_MDS option #10186
Conversation
Signed-off-by: Ali Maredia <amaredia@redhat.com>
alimaredia
changed the title
|
👍 for simplicity |
|
👍 from me too! |
tchaikov
changed the title
removes the final one (dependency of vstart on ceph-mds). Signed-off-by: J. Eric Ivancich <ivancich@redhat.com>
|
Might a better approach had been to use the WITH_CEPHFS to control building and testing of the mds library and the ceph-mds program? With this merge it's now possible to build without the ceph filesystem and the mds will nonetheless be built. |
|
@liewegas @tchaikov @jcsp @gregsfortytwo have any thoughts on what @ivancich mentioned? |
|
I'm not really aware of either of those build options, so nothing detailed. In general, building the MDS without the filesystem is weird. But you might want to be able to build the clients without building the MDS, if for instance porting/qualifying clients on weird platforms but not going through the effort of the full server. In which case maybe rename WITH_CEPHFS to WITH_CEPHFS and use WITH_CEPHFS for the full stack? |
Signed-off-by: Ali Maredia amaredia@redhat.com
This patch can merge as long as there's agreement that the WITH_MDS option can go away.