mds/MDSMap output None instead of 0 when no fs present. #10202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| f->dump_int("metadata_pool", metadata_pool); | ||
|
|
||
| if (data_pools.empty()) | ||
| f->dump_string("data_pools", "None"); |
There was a problem hiding this comment.
Let's not output None here: an empty list (the current behaviour) is more appropriate
|
I like the idea of using None/null here, but the formatter just doesn't support it so I think it doesn't make sense to use a "None" string. I like initialising metadata_pool it to -1 though. |
|
@jcsp would this looks better? if (metadata_pool == -1) { |
|
@xiaoxichen no, I don't think an empty list is better. Like I said, None/null would be good, but we just don't have a way to output that at present, so a -1 is probably the most correct thing to output. |
When no fs present, the mdsmap::dump will output metadata_pool: 0, which is misleading. Change the initial value of metadata_pool from 0 to -1. Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
|
@jcsp fixed:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no fs present, the mdsmap::dump will output metadata_pool: 0,
which is misleading.
Change the initial value of metadata_pool from 0 to -1 , and output None
when seeing -1.
Fixes: http://tracker.ceph.com/issues/16588
Signed-off-by: Xiaoxi Chen xiaoxchen@ebay.com