ceph-disk : fixes and improvements for the --data-dir code path and associated tests #1032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
aside from the ceph-osd/ceph-conf patch, this looks great to me. yay for ceph-disk tests! Reviewed-by: |
|
added 17 commits
January 3, 2014 16:30
Mainly using % instead of , Signed-off-by: Loic Dachary <loic@dachary.org>
Signed-off-by: Loic Dachary <loic@dachary.org>
Signed-off-by: Loic Dachary <loic@dachary.org>
Signed-off-by: Loic Dachary <loic@dachary.org>
Signed-off-by: Loic Dachary <loic@dachary.org>
/usr/bin is hardcoded in front of some ceph programs which makes it impossible to control where they are located via the PATH. The hardcoded path cannot be removed altogether because it will most likely lead to unexpected and difficult to diagnose problems for existing installations where the PATH finds the program elsewhere. The --prepend-to-path flag is added and defaults to /usr/bin : it prepends to the PATH environment variable. The hardcoded path is removed and the PATH will be used: since /usr/bin is searched first, the legacy behavior will not change. Signed-off-by: Loic Dachary <loic@dachary.org>
Instead of relying on a hardcoded set of if paths. Although this has the potential of changing the location of the binary being used by ceph-disk on an existing installation, it is currently only used for sgdisk. It could be disruptive for someone using a modified version of sgdisk but the odds of this happening are very low. Signed-off-by: Loic Dachary <loic@dachary.org>
The string form of a CalledProcessError instance does not include the output datamember. Add it to the Error exception for debug purposes. Signed-off-by: Loic Dachary <loic@dachary.org>
CalledProcessError has no errno data member Signed-off-by: Loic Dachary <loic@dachary.org>
Use get_conf_with_default instead of get_conf because fsid is a known ceph configuration option. It allows overriding via CEPH_ARGS which is convenient for testing. Only options that are not found in config_opts.h are fetch via get_conf. Signed-off-by: Loic Dachary <loic@dachary.org>
It is meant to be used when preparing and activating a directory that is not to be used with init. No file is created to identify the init system, no symbolic link is made to the directory in /var/lib/ceph and the init scripts are not called. Signed-off-by: Loic Dachary <loic@dachary.org>
Signed-off-by: Loic Dachary <loic@dachary.org>
Instead of failing if the OSD data directory does not exist, create it. Only do so if the data directory is not enforced to be a device via the use of the --data-dev flag. The directory is not recursively created. Signed-off-by: Loic Dachary <loic@dachary.org>
Signed-off-by: Loic Dachary <loic@dachary.org>
Replace hardcoded /var/lib/ceph with the STATEDIR global variable and implement the --statedir option to override the default value. Signed-off-by: Loic Dachary <loic@dachary.org>
Replace hardcoded /etc/ceph with the SYSCONFDIR global variable and implement the --sysconfdir option to override the default value. Signed-off-by: Loic Dachary <loic@dachary.org>
Signed-off-by: Loic Dachary <loic@dachary.org>
liewegas
pushed a commit
that referenced
this pull request
Jan 3, 2014
ceph-disk : fixes and improvements for the --data-dir code path and associated tests Reviewed-by: Sage Weil <sage@inktank.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch series is meant to make it possible to :
It adds the following features and tests:
It also fixes a number of minor bugs.