Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about snapshots #10436

Merged
merged 1 commit into from
Jul 27, 2016
Merged

Conversation

gregsfortytwo
Copy link
Member

This includes some broader developer data that should give people a base when looking at our snapshotting system. It also adds a warning about multi-FS and snapshot compatibility problems.

@gregsfortytwo
Copy link
Member Author

@ukernel and @jcsp, does this look good?

@@ -60,6 +60,11 @@ writing, but there is insufficient testing to provide stability guarantees and
every expansion of testing has generally revealed new issues. If you do enable
snapshots and experience failure, manual intervention will be needed.

Snapshots are known not to work properly with multiple filesystems (below) in
some cases. Specifically, if you share a pool for multiple FSes and delete
a snapshot in one FS, expect to lose snapshottedfile data in any other FS using
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snapshottedfile

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should add note about snapshot does not work with multiple active MDS

@@ -60,6 +60,13 @@ writing, but there is insufficient testing to provide stability guarantees and
every expansion of testing has generally revealed new issues. If you do enable
snapshots and experience failure, manual intervention will be needed.

Snapshots are known not to work properly with multiple filesystems (below) in
some cases. Specifically, if you share a pool for multiple FSes and delete
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You mean specifically sharing data pools, right? I think Doug has a patch to forbid that (it's definitely already unsafe).

Then pool sharing will become possible with, http://tracker.ceph.com/issues/15066 so I guess at that point we'll need to put something in to ensure that at most one filesystem using a particular data pool can have snapshots enabled.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah.

Signed-off-by: Greg Farnum <gfarnum@redhat.com>
@jcsp jcsp merged commit d9a0222 into ceph:master Jul 27, 2016
@gregsfortytwo gregsfortytwo deleted the wip-snapshot-doc branch October 4, 2016 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants