cmake: reconstruct the cmake files and extract one common module #10468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tone-zhang |
|
Next step would be to exclude the ARM part if running on amd64, because one way or another ARM_NEON ends up being defined on FreeBSD. Which results in tries to build code that is not compilable. |
|
@wjwithagen Thanks for you review. |
|
@dmick @cbodley @alimaredia Hi all, I have changed the PR #10427 to this one. Could you please have a review? Thanks a lot! |
Extract the CheckCompileTargets.cmake module out of src/CMakeLists.txt. It is a used to generate some the compiler options according to the CPU type. Update the CMakeLists.txt files to invoke the common module Signed-off-by: tone.zhang <tone.zhang@linaro.org>
tone-zhang
force-pushed
the
tone_cmake2
branch
from
a59b9ee
to
d781ddd
Compare
|
@tone-zhang sorry for the latency, i found that we need to pass #10956 is posted to address this. as it is based on your work, so i added your Signed-off in the commit message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR comes from cmake: fix the build on AArch64 #10427 because #10427 is polluted by myself.
I'm sorry for the inconvenience. And thanks a lot for your patience.
Extract the CheckCompileTargets.cmake module out of
src/CMakeLists.txt. It is a used to generate some the compiler options
according to the CPU type.
Update the CMakeLists.txt files to invoke the common module
Signed-off-by: tone.zhang tone.zhang@linaro.org