Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: use PERF_LOCAL_FLAGS only if defined #10828

Merged
merged 1 commit into from Aug 26, 2016
Merged

cmake: use PERF_LOCAL_FLAGS only if defined #10828

merged 1 commit into from Aug 26, 2016

Conversation

michelmno
Copy link
Contributor

in src/test/CMakeLists.txt
to avoid build error for ppc64/ppc64le archi

Fixes: http://tracker.ceph.com/issues/17104
Signed-off-by: Michel Normand normand@linux.vnet.ibm.com

@michelmno
Copy link
Contributor Author

@smithfarm I made a bypass but not sure this is the correct way to address the issue #17104

@smithfarm
Copy link
Contributor

@tchaikov @alimaredia

endif(HAVE_SSE)
if(HAVE_NEON)
set(PERF_LOCAL_FLAGS ${ARM_NEON_FLAGS})
set_target_properties(ceph_perf_local PROPERTIES COMPILE_FLAGS
${PERF_LOCAL_FLAGS})
endif(HAVE_NEON)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better off putting

if(PERF_LOCAL_FLAGS)
  set_target_properties(ceph_perf_local PROPERTIES
    COMPILE_FLAGS ${PERF_LOCAL_FLAGS})
endif()

@tchaikov tchaikov self-assigned this Aug 23, 2016
@smithfarm
Copy link
Contributor

smithfarm commented Aug 23, 2016

@michelmno The ppc64(le) build failures are gone[1], so perhaps this is no longer needed?

Nevermind.

@tchaikov tchaikov changed the title use PERF_LOCAL_FLAGS only if defined cmake: use PERF_LOCAL_FLAGS only if defined Aug 24, 2016
@tchaikov
Copy link
Contributor

@michelmno
could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#preparing-and-sending-patches, in this case, the prefix would be 'cmake: '.

in src/test/CMakeLists.txt
to avoid build error for ppc64/ppc64le archi

Fixes: http://tracker.ceph.com/issues/17104
Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
@smithfarm
Copy link
Contributor

@tchaikov If you like, I can put this through gitbuilder and an upgrade suite test.

@tchaikov
Copy link
Contributor

lgtm once gb are happy.

@smithfarm thanks. i guess as long as gitbuilders are happy, the PR is good to merge.

@smithfarm
Copy link
Contributor

pushed perf_local_flags to gitbuilder (remind self to delete it afterwards)

@smithfarm
Copy link
Contributor

@tchaikov Passes gitbuilder.

@smithfarm
Copy link
Contributor

Reviewed-by: Nathan Cutler <ncutler@suse.com>

@tchaikov tchaikov merged commit 3c6d48b into ceph:master Aug 26, 2016
@tchaikov
Copy link
Contributor

@smithfarm i removed perf_local_flags branch also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants