New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: use PERF_LOCAL_FLAGS only if defined #10828
Conversation
@smithfarm I made a bypass but not sure this is the correct way to address the issue #17104 |
endif(HAVE_SSE) | ||
if(HAVE_NEON) | ||
set(PERF_LOCAL_FLAGS ${ARM_NEON_FLAGS}) | ||
set_target_properties(ceph_perf_local PROPERTIES COMPILE_FLAGS | ||
${PERF_LOCAL_FLAGS}) | ||
endif(HAVE_NEON) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better off putting
if(PERF_LOCAL_FLAGS)
set_target_properties(ceph_perf_local PROPERTIES
COMPILE_FLAGS ${PERF_LOCAL_FLAGS})
endif()
Nevermind. |
@michelmno |
in src/test/CMakeLists.txt to avoid build error for ppc64/ppc64le archi Fixes: http://tracker.ceph.com/issues/17104 Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
@tchaikov If you like, I can put this through gitbuilder and an upgrade suite test. |
lgtm once gb are happy. @smithfarm thanks. i guess as long as gitbuilders are happy, the PR is good to merge. |
pushed |
@tchaikov Passes gitbuilder. |
|
@smithfarm i removed perf_local_flags branch also. |
in src/test/CMakeLists.txt
to avoid build error for ppc64/ppc64le archi
Fixes: http://tracker.ceph.com/issues/17104
Signed-off-by: Michel Normand normand@linux.vnet.ibm.com