os/bluestore: multithreaded '_kv_sync_thread' #10856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haodong Tang <haodong.tang@intel.com>
|
Did you observe a performance improvement with this? I'm not sure that mulitple kv commit htreads is the way to go... it seems like it won't help too much given the way that rocksdb blocks it's commits (only one in flight to disk at a time, I think). Also, I think we want to do something a bit different: ensure that each TransContext is submitted in its own thread, and the kv_sync_thread just loops and pushes them to stable storage. |
|
@liewegas There is performance improvement just when changing rocksdb to memdb. @majianpeng made more effort on optimizing multi-transaction-submission with a new PR #11189 . So I close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haodong Tang haodong.tang@intel.com