jewel: fs: client: nlink count is not maintained correctly #10877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to allow callers to specify caps to acquire during a lookup, as they may need to scrape certain info out of the inode later. Allow them to pass in a mask. For now, _lookup just passes in 0 for the mask, but verify_reply_trace passes in the regetattr_mask to match what we'd request in the _getattr request if there were a traceless reply. Signed-off-by: Jeff Layton <jlayton@redhat.com> (cherry picked from commit a2ce16f)
...and attempt to pass in a sane value there, based on what we'll do with the resulting inode. Signed-off-by: Jeff Layton <jlayton@redhat.com> (cherry picked from commit f3605d3)
…ary caps If we don't have the caps we'll need later, then we must reissue the lookup to get them regardless of whether we have a lease on the dentry. Fixes: http://tracker.ceph.com/issues/16668 Signed-off-by: Jeff Layton <jlayton@redhat.com> (cherry picked from commit 9e84767)
…he mtime The current code just looks at the sec field, but the difference may only be evident in the nsec field. Signed-off-by: Jeff Layton <jlayton@redhat.com> (cherry picked from commit 14ee7bc)
ghost
self-assigned this
ghost
pushed a commit
that referenced
this pull request
Aug 25, 2016
…ed correctly Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 10, 2016
…ed correctly Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 10, 2016
…ed correctly Reviewed-by: Loic Dachary <ldachary@redhat.com>
ghost
pushed a commit
that referenced
this pull request
Oct 13, 2016
…ed correctly Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
@jcsp does this backport look good to merge ? It passed the fs suite http://tracker.ceph.com/issues/17487#note-13 (except for one known bug that is, I believe, unrelated) |
ghost
pushed a commit
that referenced
this pull request
Oct 17, 2016
…ed correctly Reviewed-by: Loic Dachary <ldachary@redhat.com>
|
👍 |
ghost
merged commit 
theanalyst
changed the title
theanalyst
changed the title
theanalyst
changed the title
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/16946