osd: OSDMap: build reverse name->pool map upon decoding #1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 3d7c69f introduced a new OSDMap encoding/decoding scheme. However, while the classic decoding function still kept building the reverse name->pool map, the new decoding function did not, causing the monitor to be unable to map pool names to pool ids. This patch fixes this, by factoring out the loop responsible for populating the 'name_pool' map, as well as calling 'calc_num_osds()', to OSDMap::post_decode() and having this function called from both the classic and the new decode functions. Fixes: 7166 Signed-off-by: Joao Eduardo Luis <jecluis@gmail.com>
|
http://gitbuilder.sepia.ceph.com/gitbuilder-ceph-tarball-precise-amd64-basic/log.cgi?log=1aa2601818cef481ed68c350f98c7e1fca911b97 passes : it previously failed because of the error. I also find that local compilation + make check works. The other two gitbuilder URLs fail for reasons unrelated to the fix or the original error ( timeout is too short and machines are too slow ). |
ghost
pushed a commit
that referenced
this pull request
Jan 16, 2014
osd: OSDMap: build reverse name->pool map upon decoding Reviewed-by: Loic Dachary <loic@dachary.org>
ghost
merged commit 
liewegas
pushed a commit
to liewegas/ceph
that referenced
this pull request
Nov 18, 2016
packages.yaml: reflect python-ceph package split
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 3d7c69f introduced a new OSDMap encoding/decoding scheme.
However, while the classic decoding function still kept building the
reverse name->pool map, the new decoding function did not, causing the
monitor to be unable to map pool names to pool ids.
This patch fixes this, by factoring out the loop responsible for
populating the 'name_pool' map, as well as calling 'calc_num_osds()', to
OSDMap::post_decode() and having this function called from both the
classic and the new decode functions.
Fixes: 7166
Signed-off-by: Joao Eduardo Luis jecluis@gmail.com