rgw: ignore fields placed after "file" in S3's browser uploads. #11066
Conversation
|
@rzarzynski this looks still relevant, but the commit is also in 11179? Is this needed separately? |
|
@mattbenjamin: the commit is present also in #11179 as a dependency. I still keep this PR open to allow merging the fix separately (FormPost is quite big). |
|
@rzarzynski please rebase |
rzarzynski
force-pushed
the
wip-rgw-17273
branch
from
875268e
to
d57b3fc
Compare
|
@oritwas: rebased. The conflict was trivial and related to the |
src/rgw/rgw_rest_s3.cc
Outdated
|
|
||
| if (boundary) { | ||
| data_pending = false; | ||
|
|
||
| if (!done) { /* reached end of data, let's drain the rest of the params */ |
There was a problem hiding this comment.
I agree we should not parse the arguments but I think we should read all the data.
rzarzynski
force-pushed
the
wip-rgw-17273
branch
from
d57b3fc
to
bca8d15
Compare
|
@oritwas: just addressed the data draining, rebased to fresh |
Fixes: http://tracker.ceph.com/issues/17273 Signed-off-by: Radoslaw Zarzynski <rzarzynski@mirantis.com>
rzarzynski
force-pushed
the
wip-rgw-17273
branch
from
bca8d15
to
630966f
Compare
|
Fixed an obvious thinko. The patch was positively verified together with FormPost-related commits in PR #11179. |
|
jenkins test this please |
|
jenkins test this please (unrelated test failure) |
|
jenkins test this please (due to: |
|
jenkins test this please |
|
The commit has been merged as a part of #11179. Closing. |
Fixes: http://tracker.ceph.com/issues/17273
Signed-off-by: Radoslaw Zarzynski rzarzynski@mirantis.com