Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: use a fixture for memstore clone testing #11190

Merged
merged 3 commits into from Sep 22, 2016
Merged

tests: use a fixture for memstore clone testing #11190

merged 3 commits into from Sep 22, 2016

Commits on Sep 22, 2016

  1. ceph_test_objectstore: extract StoreTestFixture into store_test_fixtu… 

    …re.cc

so it can be reused by other tests like test_memstore_clone.

Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    7f4dff2 View commit details
    Browse the repository at this point in the history

  2. ceph_test_objectstore: fail the test if SetUp() fails 

    so it will issues a fatal error if anything goes wrong, instead of continuing
with the test cases.

Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    afac934 View commit details
    Browse the repository at this point in the history

  3. test_memstore_clone: use StoreTestFixture to do the setup/teardown 

    rename test case name from `MemStore` to `MemStoreClone`, because
if we use `TEST_F` to group the tests into a fixture, `MemStore`
will be used as the class name of the fixture, and hence conflicts
with the existing `MemStore` class under testing.

but the object store is created and destroyed for every test. before
this change, we do this for every test case. if it's a concern
we need to use SetUpTestCase() and TearDownTestCase() instead.

Signed-off-by: Kefu Chai <kchai@redhat.com>
    @tchaikov
    tchaikov committed Sep 22, 2016
    Configuration menu
    Copy the full SHA
    0cad3dc View commit details
    Browse the repository at this point in the history