Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

os/bluestore: pack a few more in-memory types #11328

Merged
merged 6 commits into from Oct 6, 2016
Merged

os/bluestore: pack a few more in-memory types #11328

merged 6 commits into from Oct 6, 2016

Commits on Oct 4, 2016

  1. os/bluestore: pack Blob members 

    272 -> 264 bytes

Signed-off-by: Sage Weil <sage@redhat.com>
    @liewegas
    liewegas committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    2094168 View commit details
    Browse the repository at this point in the history

  2. os/bluestore: pack SharedBlob 

    224 -> 216 bytes

Signed-off-by: Sage Weil <sage@redhat.com>
    @liewegas
    liewegas committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    7c5b77a View commit details
    Browse the repository at this point in the history

  3. os/bluestore: make BufferSpace smaller 

    Saves 24 bytes!

BufferSpace  104 -> 80 bytes
SharedBlob   216 -> 192 bytes

Signed-off-by: Sage Weil <sage@redhat.com>
    @liewegas
    liewegas committed Oct 4, 2016
    Configuration menu
    Copy the full SHA
    02f4571 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2016

  1. os/bluestore: make Buffer smaller 

    160 -> 152 bytes

Signed-off-by: Sage Weil <sage@redhat.com>
    @liewegas
    liewegas committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    871aa4a View commit details
    Browse the repository at this point in the history

  2. unittest_bluestore_types: more type sizeofs 

    Signed-off-by: Sage Weil <sage@redhat.com>
    @liewegas
    liewegas committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    6bbac0e View commit details
    Browse the repository at this point in the history

  3. os/bluestore: simplify BufferSpace writing_map / list 

    We were tracking buffers by seq.  In reality, though, we
won't have very many buffers that have in flight IO to
the same blob at the same time, so we can get by with
just a list here.  We can rely on the fact that the
list will be sorted (seq's increase, and we put new
buffers at the end).

This saves us a memory allocation.  No change in size of
BufferSpace and Blob (std::list -> intrusive::list).

Signed-off-by: Sage Weil <sage@redhat.com>
    @liewegas
    liewegas committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    0932d39 View commit details
    Browse the repository at this point in the history