New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
jewel: rbd: rbd-nbd IO hang #11467
jewel: rbd: rbd-nbd IO hang #11467
Conversation
CXX test/librbd/operation/unittest_librbd-test_mock_SnapshotRemoveRequest.o CXX test/librbd/operation/unittest_librbd-test_mock_SnapshotRollbackRequest.o test/librbd/operation/test_mock_ResizeRequest.cc: In member function ‘virtual void librbd::operation::TestMockOperationResizeRequest_FlushCacheError_Test::TestBody()’: test/librbd/operation/test_mock_ResizeRequest.cc:298:315: error: no matching function for call to ‘librbd::operation::TestMockOperationResizeRequest_FlushCacheError_Test::when_resize(librbd::MockImageCtx&, uint64_t, bool, int, bool)’ ASSERT_EQ(-EINVAL, when_resize(mock_image_ctx, ictx->size / 2, true, 0, false)); ^ test/librbd/operation/test_mock_ResizeRequest.cc:298:315: note: candidate is: test/librbd/operation/test_mock_ResizeRequest.cc:136:7: note: int librbd::operation::TestMockOperationResizeRequest::when_resize(librbd::MockImageCtx&, uint64_t, uint64_t, bool) int when_resize(MockImageCtx &mock_image_ctx, uint64_t new_size, ^ test/librbd/operation/test_mock_ResizeRequest.cc:136:7: note: candidate expects 4 arguments, 5 provided MockImageCtx should be MockImageTestCtx or something, introduced after this commit but backported before it |
@dachary Do you need help with this PR so we can get the nbd tests functional? |
I think I can manage it, I'll ask for help if I'm stuck. Will work on it in the next 24h. |
Fixes: http://tracker.ceph.com/issues/16921 Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit ce7c152)
Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit c6cfb61)
Any potential writeback outside the extents of a shrunk image would result in orphaned objects. Signed-off-by: Jason Dillaman <dillaman@redhat.com> (cherry picked from commit 3f93a19)
jenkins test this please (rbd core) |
building in gitbuilder under wip-17262-jewel |
jenkins test this please (rbd failure again) http://tracker.ceph.com/issues/17642 |
retest this please |
filter="rbd/thrash/{base/install.yaml clusters/{fixed-2.yaml openstack.yaml} fs/xfs.yaml msgr-failures/few.yaml thrashers/cache.yaml workloads/rbd_fsx_nbd.yaml}" teuthology-suite --priority 101 --suite rbd --filter="$filter" --suite-branch jewel --email loic@dachary.org --ceph wip-17262-jewel --machine-type smithi |
@dachary hmm -- assertion failure in the daemon on one test run but no coredump generated. |
Re-running the above to assert how transient (or not) the failure is |
@dachary Let me re-run it a few times w/ rbd debugging enabled to see if I can repeat it today. |
@dachary This failure is something different -- I am going to try to get a coredump out of this. |
@dachary This PR is good to merge -- but I need to open a new ticket for the associated crash since it's high-pri and isn't related to this change. |
http://tracker.ceph.com/issues/17262