rgw: fix rgw crash when client post object with null conditions #11573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diluga next time, you can |
yehudasa
reviewed
Oct 20, 2016
| @@ -276,6 +276,10 @@ int RGWPolicy::from_json(bufferlist& bl, string& err_msg) | |||
| int i; | |||
| for (i = 0; !citer.end() && i < 3; ++citer, ++i) { | |||
| JSONObj *o = *citer; | |||
| const string condition_data = o->get_data(); | |||
There was a problem hiding this comment.
thx！i have chage the code，push it again！
|
@diluga does that fix it for you? Please see my fix here: https://github.com/yehudasa/ceph/tree/wip-11573-hammer |
|
@diluga should be this: https://github.com/yehudasa/ceph/tree/wip-17635-hammer |
Fixes: http://tracker.ceph.com/issues/17635 Signed-off-by: Feng Guo <diluga@gmail.com>
|
@yehudasa https://github.com/yehudasa/ceph/tree/wip-17635-hammer i have test it，it worked！ |
|
fixed in #11581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/17635
Signed-off-by: Feng Guo diluga@gmail.com