Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: ignore 'session evict' when mds is replaying log #11813

Merged
merged 1 commit into from Nov 21, 2016

Conversation

ukernel
Copy link
Contributor

@ukernel ukernel commented Nov 7, 2016

Fixes: http://tracker.ceph.com/issues/17801
Signed-off-by: Yan, Zheng zyan@redhat.com

@ukernel ukernel added bug-fix cephfs Ceph File System labels Nov 7, 2016
@liewegas liewegas added this to the kraken milestone Nov 8, 2016
Copy link
Contributor

@jcsp jcsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from the comment about return code

C_MDS_Send_Command_Reply *reply = new C_MDS_Send_Command_Reply(this, m);

if (is_any_replay()) {
reply->send(-EINVAL, "MDS is replaying log");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's return -EAGAIN instead, so that a caller can tell the difference between this case and the case where their filter expression was invalid

@jcsp
Copy link
Contributor

jcsp commented Nov 11, 2016

@jcsp jcsp merged commit 9773abb into ceph:master Nov 21, 2016
@ukernel ukernel deleted the wip-17801 branch January 12, 2017 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix cephfs Ceph File System
Projects
None yet
3 participants